Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.2k
Text repr: remove "Dimensions without coordinates" section#10489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
I was never a big fan of "Dimensions without coordinates"! This message does provide a gentle nudge to annotate coordinates on all dimensions, but I'm not sure that's appropriate or necessary. Xarray would definitely be a bit tidier for non-coordinate users if this section was not shown. Digging back through when we added this, these issues provide the original context: In particular, the complaint was that it could be hard to notice missing coordinates on |
The
Dimensions without coordinates
section of the Dataset and DataArray text reprs was useful in the context of dimension coordinates with a default index. Since the index refactor, however, it may be more confusing than useful and even inaccurate in the case of non-dimension coordinate or multi-coordinate indexes.I took the bold step of simply removing that section in this PR. I don't know who is really paying attention to it nowadays, though (there's no equivalent in the html reprs). Alternatively we could keep it and try listing the dimensions more accurately.