Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

drop_incomplete support in SeasonGrouper#10436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dhruvak001 wants to merge5 commits intopydata:main
base:main
Choose a base branch
Loading
fromdhruvak001:issue#10426

Conversation

dhruvak001
Copy link
Contributor

@dhruvak001dhruvak001 commentedJun 21, 2025
edited
Loading

SeasonGrouper Enhancements

Enhanced theSeasonGrouper class to support conditional omission of incomplete seasons—now aligned with behavior inSeasonResampler.


Summary of Changes

1.drop_incomplete Keyword Argument

  • Introduced a new boolean parameterdrop_incomplete, defaulting toFalse for backward compatibility.
  • Enables users to choose whether incomplete seasons should be excluded during grouping.

2. Revisedfactorize Method

  • Core logic for dropping incomplete seasons has been moved into thefactorize method.
  • Whendrop_incomplete=True, it:
    • Iterates over each year-series chunk.
    • Verifies that all expected months in the season are present.
    • Excludes any data for that season-year pair if months are missing.

3. Updatedreset Method

  • Ensures that thedrop_incomplete setting correctly propagates when resetting or re-initializing the grouper.

@welcomeWelcome
Copy link

welcomebot commentedJun 21, 2025

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in ourcontributing guidelines.

@dhruvak001
Copy link
ContributorAuthor

dhruvak001 commentedJul 4, 2025
edited
Loading

@dcherian the failing tests seems to be unrelated to changes in the PR, right?

@dhruvak001dhruvak001 requested a review fromdcherianJuly 4, 2025 03:01
@dcherian
Copy link
Contributor

Yes.

Apologies, I am quite busy at the moment and can only review this in two weeks.

@tomvothecoder if you happen to have tests for grouping withdrop_incomplete, those would be very helpful here.

dhruvak001 reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dcheriandcherianAwaiting requested review from dcherian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supportdrop_incomplete kwarg withSeasonGrouper
2 participants
@dhruvak001@dcherian

[8]ページ先頭

©2009-2025 Movatter.jp