Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.2k
drop_incomplete support in SeasonGrouper#10436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
Uh oh!
There was an error while loading.Please reload this page.
dhruvak001 commentedJul 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@dcherian the failing tests seems to be unrelated to changes in the PR, right? |
Yes. Apologies, I am quite busy at the moment and can only review this in two weeks. @tomvothecoder if you happen to have tests for grouping with |
Uh oh!
There was an error while loading.Please reload this page.
drop_incomplete
kwarg withSeasonGrouper
#10426whats-new.rst
api.rst
SeasonGrouper Enhancements
Enhanced the
SeasonGrouper
class to support conditional omission of incomplete seasons—now aligned with behavior inSeasonResampler
.Summary of Changes
1.
drop_incomplete
Keyword Argumentdrop_incomplete
, defaulting toFalse
for backward compatibility.2. Revised
factorize
Methodfactorize
method.drop_incomplete=True
, it:3. Updated
reset
Methoddrop_incomplete
setting correctly propagates when resetting or re-initializing the grouper.