Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow for inline_array specification in open_zarr through from_array_kwargs#10373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
hansmohrmann wants to merge1 commit intopydata:main
base:main
Choose a base branch
Loading
fromhansmohrmann:allow-inline-array-for-open-zarr

Conversation

hansmohrmann
Copy link

This is probably not the best way to do this, but I figured I would start with the simplest way and go from there.

inline_array snakes its way through the codebase all the way to_maybe_chunk where it getsresolved against from_array_kwargs; if you provide it infrom_array_kwargsand explicitly toopen_dataset, you get@dcherian's error message. So withopen_zarr you can't provide it infrom_array_kwargs since the default open_dataset value is used (False); this PR just removes it from from_array_kwargs and passes that value to open_dataset.

Pros:

  • Doesn't require changing the signature of anything.

Cons:

  • open_zarr is now the one place where you can useinline_array infrom_array_kwargs, which might lead to some confusion down the line.
  • Have tied the default value inopen_dataset toopen_zarr.

So alternatively, I could modifyopen_zarr with anotherinline_array arg.

@welcomeWelcome
Copy link

welcomebot commentedMay 29, 2025

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in ourcontributing guidelines.

@hansmohrmann
Copy link
Author

@TomNicholas

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
iotopic-backendstopic-zarrRelated to zarr storage library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supportinline_array kwarg inopen_zarr
2 participants
@hansmohrmann@dcherian

[8]ページ先頭

©2009-2025 Movatter.jp