Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.2k
Allow for inline_array specification in open_zarr through from_array_kwargs#10373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
hansmohrmann wants to merge1 commit intopydata:mainChoose a base branch fromhansmohrmann:allow-inline-array-for-open-zarr
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Allow for inline_array specification in open_zarr through from_array_kwargs#10373
hansmohrmann wants to merge1 commit intopydata:mainfromhansmohrmann:allow-inline-array-for-open-zarr
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is probably not the best way to do this, but I figured I would start with the simplest way and go from there.
inline_array
snakes its way through the codebase all the way to_maybe_chunk where it getsresolved against from_array_kwargs; if you provide it infrom_array_kwargs
and explicitly toopen_dataset
, you get@dcherian's error message. So withopen_zarr
you can't provide it infrom_array_kwargs
since the default open_dataset value is used (False); this PR just removes it from from_array_kwargs and passes that value to open_dataset.Pros:
Cons:
open_zarr
is now the one place where you can useinline_array
infrom_array_kwargs
, which might lead to some confusion down the line.open_dataset
toopen_zarr
.So alternatively, I could modify
open_zarr
with anotherinline_array
arg.inline_array
kwarg inopen_zarr
#8095