Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

add **encoding** argument in netCDF4 backend#10372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
wqshen wants to merge2 commits intopydata:main
base:main
Choose a base branch
Loading
fromwqshen:master

Conversation

wqshen
Copy link

addencoding argument in netCDF4 backend to support reading NetCDF file with non-ASCII path or filename.

The behavior is consistent with upstream netCDF4 library, default path encoding is set tosys.getdefaultfileencoding() .

…ile with non-ASCII path or filename and keep consistent behavior with upstream netcdf4 library
@welcomeWelcome
Copy link

welcomebot commentedMay 29, 2025

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in ourcontributing guidelines.

@dcherian
Copy link
Contributor

dcherian commentedMay 29, 2025•
edited
Loading

Nice, can you add a test here please?

classTestNetCDF4Data(NetCDF4Base):

It can simply roundtrip a simple dataset to a file with a filename that doesn't work today.

@kmuehlbauer
Copy link
Contributor

How is this handled in the light of this comment#9282 (comment) by@dcherian?

@dcherian
Copy link
Contributor

Hah! Probably good to usefilename_encoding since we'll probably to support writing files with such file names.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support anencoding parameter when reading netCDF files with xarray
3 participants
@wqshen@dcherian@kmuehlbauer
[8]ページ先頭
©2009-2025 Movatter.jp