Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork132
[WIP] CSR/ CSC Elemwise#465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
* Still has some failing tests* No benchmarks* No tests for unary ops* No support for functions with arity > 2 (what even are these functions)
Thanks for this,@ivirshup. Let me know if you need any help or direction. |
codecovbot commentedJul 20, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #465 +/- ##==========================================- Coverage 92.15% 90.91% -1.24%========================================== Files 20 21 +1 Lines 3313 3445 +132 ==========================================+ Hits 3053 3132 +79- Misses 260 313 +53 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
CodeQL found more than 10 potential problems in the proposed changes. Check theFiles changed tab for more details.
@ivirshup Do you plan to continue this? |
I have some interest but probably not time. I would love for someone to take it over. IIRC the biggest stumbling block was dispatch. If that could get worked out by someone else, I'd be interested in collaborating. |
Uh oh!
There was an error while loading.Please reload this page.
Very WIP draft PR for elemwise operations on CSR and CSC arrays.
Currently just implements broadcasting operations between compressed 2d arrays. Cases that would be covered by a full implementation:
-a
)A quick benchmark:
Should provide some insight for#460