Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add dismiss button to announcement banner#2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jorisvandenbossche wants to merge1 commit intopydata:main
base:main
Choose a base branch
Loading
fromjorisvandenbossche:dismissable-announcement-banner

Conversation

@jorisvandenbossche
Copy link
Member

@jorisvandenbosschejorisvandenbossche commentedDec 12, 2025
edited by drammock
Loading

Addresses#1384

Using essentially the same approach as was used for the version warning banner in#1763

Some questions for the announcement banner compared to the versions:

  • Do we also want to only remember it for 14 days, or just forever for a certain announcement?
  • Ideally the stored dismiss state takes into account the content of the announcement, so that when you add a new announcement, all users see it?
  • I am assuming that for a general announcement banner, we donot want this to be version specific (i.e. remember it separately per version)

Note: I only tested it with a remote announcement that gets injected, not yet with a local snippet.

@jorisvandenbossche
Copy link
MemberAuthor

This seems to work on the readthedocs preview as well:https://pydata-sphinx-theme--2287.org.readthedocs.build/en/2287/index.html

I am only not sure why the alignment of the close button seems to be different (left vs right) for the announcement vs version warning banner, as I don't see any difference in css

@Carreau
Copy link
Collaborator

Dismissing for 14 days is already a great step forward. I will try to review/merge that before end of month, but no promises.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jorisvandenbossche@Carreau

[8]ページ先頭

©2009-2025 Movatter.jp