- Notifications
You must be signed in to change notification settings - Fork358
feat: add dismiss button to announcement banner#2287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
feat: add dismiss button to announcement banner#2287
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jorisvandenbossche commentedDec 12, 2025
This seems to work on the readthedocs preview as well:https://pydata-sphinx-theme--2287.org.readthedocs.build/en/2287/index.html I am only not sure why the alignment of the close button seems to be different (left vs right) for the announcement vs version warning banner, as I don't see any difference in css |
Carreau commentedDec 14, 2025
Dismissing for 14 days is already a great step forward. I will try to review/merge that before end of month, but no promises. |
Uh oh!
There was an error while loading.Please reload this page.
Addresses#1384
Using essentially the same approach as was used for the version warning banner in#1763
Some questions for the announcement banner compared to the versions:
Note: I only tested it with a remote announcement that gets injected, not yet with a local snippet.