Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

pass sse_read_timeout to MCP ClientSession read_timeout_seconds#2240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
AntSan813 wants to merge10 commits intopydantic:main
base:main
Choose a base branch
Loading
fromAntSan813:add-read-timeout-seconds

Conversation

AntSan813
Copy link

@AntSan813AntSan813 commentedJul 17, 2025
edited
Loading

fixes#2222

@DouweMDouweM self-assigned thisJul 18, 2025
@@ -59,6 +60,7 @@ class MCPServer(AbstractToolset[Any], ABC):
log_level:mcp_types.LoggingLevel|None=None
log_handler:LoggingFnT|None=None
timeout:float=5
sse_read_timeout:float=5*60
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we call thisread_timeout as it's not SSE specific anymore? We'd still want to keep thesse_read_timeout argument on constructor to_MCPServerHTTP subclasses for backward compatibility, but we can set the new property and print a deprecation warning. We'd likely need to define a custom__init__ and passinit=False to@dataclass.

Let me know if you'd like some more guidance!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sounds good, thanks for reviewing.

I mappedsse_read_timeout toread_timeout and added a deprecation warning. I also updated the tests. Let me know if I misused the dataclass setup -- still learning the python way.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@DouweMDouweMDouweM requested changes

Assignees

@DouweMDouweM

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add read_timeout_seconds to MCPServerStreamableHTTP
2 participants
@AntSan813@DouweM

[8]ページ先頭

©2009-2025 Movatter.jp