- Notifications
You must be signed in to change notification settings - Fork1k
Fix include_content not working as expected#2206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Fix include_content not working as expected#2206
Conversation
) | ||
if not instrumentation_settings or instrumentation_settings.include_content: | ||
run_span.set_attribute( | ||
'final_result', |
adtyavrdhnJul 15, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this should also be removed if the flag is set to False, let me know if you think otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
agreed
Sorry about the missed parts, I think this covers everything now. Please take a look |
Please rename the PR for the changelog |
Uh oh!
There was an error while loading.Please reload this page.
Fixes#1571
Fixes include_content = False not working as expected for instructions and final_result