Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix include_content not working as expected#2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
adtyavrdhn wants to merge2 commits intopydantic:main
base:main
Choose a base branch
Loading
fromadtyavrdhn:include_content_instructions_final_result

Conversation

adtyavrdhn
Copy link
Contributor

@adtyavrdhnadtyavrdhn commentedJul 15, 2025
edited
Loading

Fixes#1571

Fixes include_content = False not working as expected for instructions and final_result

)
if not instrumentation_settings or instrumentation_settings.include_content:
run_span.set_attribute(
'final_result',
Copy link
ContributorAuthor

@adtyavrdhnadtyavrdhnJul 15, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this should also be removed if the flag is set to False, let me know if you think otherwise

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

agreed

@adtyavrdhnadtyavrdhn marked this pull request as ready for reviewJuly 15, 2025 14:47
@adtyavrdhnadtyavrdhn marked this pull request as draftJuly 15, 2025 14:50
@adtyavrdhn
Copy link
ContributorAuthor

@alexmojaki

Sorry about the missed parts, I think this covers everything now. Please take a look

@adtyavrdhnadtyavrdhn marked this pull request as ready for reviewJuly 15, 2025 14:56
@alexmojaki
Copy link
Contributor

Please rename the PR for the changelog

@adtyavrdhnadtyavrdhn changed the titleeither instrumentation setting include_content is set to False or it …Fix include_conent not working as expectedJul 15, 2025
@adtyavrdhnadtyavrdhn changed the titleFix include_conent not working as expectedFix include_content not working as expectedJul 15, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@alexmojakialexmojakialexmojaki left review comments

Assignees

@alexmojakialexmojaki

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a setting to remove prompts and completions from tracing
3 participants
@adtyavrdhn@alexmojaki@DouweM

[8]ページ先頭

©2009-2025 Movatter.jp