- Notifications
You must be signed in to change notification settings - Fork1k
chore: disable python 3.9 coverage#2178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Disable python 3.9 coverage in CI as it can get the wrong line numbersresulting in unsolvable coverage errors, as it conflicts with 3.10+.
ea7c21c
to6e86db5
Compare484022f
intopydantic:main 18 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Disable python 3.9 coverage in CI as it can get the wrong line numbers resulting in unsolvable coverage errors, as it conflicts with 3.10+.
pep-0626 (3.10) introduced accurate line number tracking.
There's an example of 3.9 getting the wrong line number in
tests/test_direct.py
which is now covered with a# pragma: no cover
This was discovered when developing the AG-UI feature, where multiple
if
elif
blocks were flagged covered by 3.9 but not by other versions, which resulted in failure cycle of not covered and incorrectly marked as not covered.