- Notifications
You must be signed in to change notification settings - Fork1k
duckduckgo-search
is renamed toddgs
#2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
PR Change SummaryRenamed the
Modified Files
How can I customize these reviews?Check out theHyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
from duckduckgo_search import DDGS | ||
try: | ||
from ddgs import DDGS | ||
except ImportError: # Fallback for older versions of ddgs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think wecould skip this try-except.
Currently, I am seeing warnings like:```/Users/bas.nijholt/agent-cli/.venv/lib/python3.11/site-packages/pydantic_ai/common_tools/duckduckgo.py:68:RuntimeWarning: This package (`duckduckgo_search`) has been renamed to `ddgs`! Use `pip install ddgs` instead. DuckDuckGoSearchTool(client=duckduckgo_client or DDGS(), max_results=max_results).__call__,```
fswair commentedJul 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
... |
@fswair Only if they used the |
@basnijholt The linter is not loving it though 😅 Can you have a look to see what's going on? |
fswair commentedJul 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Then@basnijholt may you add some pyright ignore directives in the lines that causes lint errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks :)
1130748
intopydantic:mainUh oh!
There was an error while loading.Please reload this page.
Currently, I am seeing warnings like: