Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

duckduckgo-search is renamed toddgs#2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Kludex merged 4 commits intopydantic:mainfrombasnijholt:ddgs
Jul 15, 2025
Merged

Conversation

basnijholt
Copy link
Contributor

Currently, I am seeing warnings like:

/Users/bas.nijholt/agent-cli/.venv/lib/python3.11/site-packages/pydantic_ai/common_tools/duckduckgo.py:68:RuntimeWarning: This package (`duckduckgo_search`) has been renamed to `ddgs`! Use `pip install ddgs` instead.  DuckDuckGoSearchTool(client=duckduckgo_client or DDGS(), max_results=max_results).__call__,

@hyperlint-aiHyperlint AI
Copy link
Contributor

PR Change Summary

Renamed theduckduckgo-search package toddgs in the documentation to reflect the recent changes in package naming.

  • Updated installation instructions to useddgs instead ofduckduckgo-search
  • Modified references to theDuckDuckGoSearchRun tool to reflect the new package name
  • Removed warnings related to the old package name in the documentation

Modified Files

  • docs/install.md
  • docs/tools.md

How can I customize these reviews?

Check out theHyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add thehyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to addhyperlint-ignore to the PR to ignore the link check for this PR.

from duckduckgo_search import DDGS
try:
from ddgs import DDGS
except ImportError: # Fallback for older versions of ddgs
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think wecould skip this try-except.

Currently, I am seeing warnings like:```/Users/bas.nijholt/agent-cli/.venv/lib/python3.11/site-packages/pydantic_ai/common_tools/duckduckgo.py:68:RuntimeWarning: This package (`duckduckgo_search`) has been renamed to `ddgs`! Use `pip install ddgs` instead.  DuckDuckGoSearchTool(client=duckduckgo_client or DDGS(), max_results=max_results).__call__,```
@fswair
Copy link
Contributor

fswair commentedJul 10, 2025
edited
Loading

...

@DouweM
Copy link
Contributor

If user installs latest version of pyai, also gets the latest version of duckduckgo

@fswair Only if they used theduckduckgo optional dependency group to install it, rather than installing it directly. I think the extra import attempt is fine so we don't break existing installations.

fswair reacted with thumbs up emoji

@DouweM
Copy link
Contributor

@basnijholt The linter is not loving it though 😅 Can you have a look to see what's going on?

@fswair
Copy link
Contributor

fswair commentedJul 10, 2025
edited
Loading

@basnijholt The linter is not loving it though 😅 Can you have a look to see what's going on?

Then@basnijholt may you add some pyright ignore directives in the lines that causes lint errors.

Copy link
Member

@KludexKludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks :)

@KludexKludexenabled auto-merge (squash)July 15, 2025 10:32
@KludexKludex merged commit1130748 intopydantic:mainJul 15, 2025
17 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@KludexKludexKludex approved these changes

Assignees

@DouweMDouweM

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@basnijholt@fswair@DouweM@Kludex

[8]ページ先頭

©2009-2025 Movatter.jp