I've updated known model list with new OpenAI version, fixed MistralAItest issue in new version, added new ResourceLink MCP type and fixed tests for new MCP version.

Update tests to be compatible with new OpenAI, MistralAI and MCP vers…

c1dfca6

…ions

Copy link

Contributor

hyperlint-aibot commentedJun 28, 2025

PR Change Summary

Updated tests to ensure compatibility with the latest versions of OpenAI, MistralAI, and MCP.

Updated known model list with the new OpenAI version
Fixed MistralAI test issue in the new version
Adjusted tests for compatibility with the new MCP version

Modified Files

docs/mcp/server.md

How can I customize these reviews?

Check out theHyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add thehyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to addhyperlint-ignore to the PR to ignore the link check for this PR.

Fix mcp compatibility

8d42e69

medaminezghal commented

Jun 28, 2025

View reviewed changes

pydantic_ai_slim/pydantic_ai/mcp.pyShow resolvedHide resolved

medaminezghal added2 commits

June 28, 2025 14:24

add ResourceLink type

290becb

add ResourceLink type

a60e11d

DouweM requested changes

Jun 30, 2025

View reviewed changes

Copy link

Contributor

DouweM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@medaminezghal Thanks Mohamed! The only thing I'm not sure about is how we should handleResourceLink.

pydantic_ai_slim/pydantic_ai/mcp.py OutdatedShow resolvedHide resolved

DouweM self-assigned this

Jun 30, 2025

Copy link

Contributor

DouweM commentedJul 1, 2025

@medaminezghal Can you please have a look at the failing coverage check?

DouweM added the awaiting author revision label

Jul 1, 2025

medaminezghal added2 commits

July 5, 2025 06:11

Merge branch 'main' into update-versins

7d98900

Fix ResourceLink MCP types

749c71d

DouweM requested changes

Jul 8, 2025

View reviewed changes

docs/graph.md OutdatedShow resolvedHide resolved

docs/models/google.md OutdatedShow resolvedHide resolved

pydantic_ai_slim/pydantic_ai/mcp.py OutdatedShow resolvedHide resolved

pydantic_ai_slim/pydantic_ai/mcp.pyShow resolvedHide resolved

pydantic_ai_slim/pydantic_ai/mcp.py OutdatedShow resolvedHide resolved

Fix

7b83106

medaminezghal force-pushed theupdate-versins branch fromdd0f644 to7b83106Compare

July 9, 2025 05:42

Copy link

ContributorAuthor

medaminezghal commentedJul 9, 2025•
edited
Loading

@DouweM Does it need to add some tests to fix coverage problem?

Merge branch 'main' into update-versins

2091142

DouweM requested changes

Jul 9, 2025

View reviewed changes

pydantic_ai_slim/pydantic_ai/mcp.py OutdatedShow resolvedHide resolved

Copy link

Contributor

DouweM commentedJul 9, 2025

Does it need to add some tests to fix coverage problem?

@medaminezghal Yep, there are already a number oftest_tool_returning_<x> tests intests/test_mcp.py, and we'll want one forResourceLink. The test MCP server it uses is defined intests/mcp_server.py, so that's where you'll want to add a new@mcp.tool that returns aResourceLink, as well as an@mcp.resource that will return that actual resource once it's looked up.

Copy link

ContributorAuthor

medaminezghal commentedJul 9, 2025•
edited
Loading

Does it need to add some tests to fix coverage problem?
@medaminezghal Yep, there are already a number oftest_tool_returning_<x> tests intests/test_mcp.py, and we'll want one forResourceLink. The test MCP server it uses is defined intests/mcp_server.py, so that's where you'll want to add a new@mcp.tool that returns aResourceLink, as well as an@mcp.resource that will return that actual resource once it's looked up.

Do I need a real API key to usemake update-vcr-tests?

Copy link

Contributor

DouweM commentedJul 9, 2025•
edited
Loading

@medaminezghal I wouldn't usemake update-vcr-tests as it will try to update every single cassette. To just record a cassette for your own test, you can runpytest --record-mode=rewrite <test file path>::<test function name>. If the test uses a real model, you do need an API key.

Copy link

ContributorAuthor

medaminezghal commentedJul 9, 2025

@DouweM I don't have any API key to use it for tests, so, themake update-vcr-tests will not work.

Do you think I should use one of the file insidetests/assets/ for theResourceLink?

For example:

@mcp.tool()async def get_resource_link() -> ResourceLink:    return ResourceLink(        type='resource_link',        uri=AnyUrl(Path(__file__).parent.joinpath('assets/kiwi.png').absolute().as_uri()),        name='kiwi.png',    )

Copy link

Contributor

DouweM commentedJul 9, 2025

@medaminezghal I think you should only need the actual full file path in the@mcp.resource function that actually reads the resource, but yes using that file is great!

If you have your own OpenAI API key, you can generate the cassette for your new test with that, but if not feel free to push up the test and I can generate the cassette myself locally.

Copy link

ContributorAuthor

medaminezghal commentedJul 10, 2025

@DouweM I will just duplicate the tests that useEmbeddedResource to useResourceLink.

medaminezghal added4 commits

July 10, 2025 21:37

Add tests

6766617

Merge branch 'main' into update-versins

8c32055

Fix tests fails for new cohere version

7e1c180

Merge branch 'main' into update-versins

5d3112f

DouweM requested changes

Jul 16, 2025

View reviewed changes

Copy link

Contributor

DouweM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@medaminezghal I was out for a few days but just had a chance to review this again. Please have a look at my comments and let me know if I can provide additional guidance (or take over).

pydantic_ai_slim/pydantic_ai/models/cohere.py OutdatedShow resolvedHide resolved

tests/mcp_server.py OutdatedShow resolvedHide resolved

tests/mcp_server.py

		async def get_image_resource_1() -> ResourceLink:
		return ResourceLink(
		type='resource_link',
		uri=AnyUrl(Path(__file__).parent.joinpath('assets/kiwi.png').absolute().as_uri()),

Copy link

Contributor

DouweMJul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Does this need to be the full path? Couldn't it beAnyUrl('resource://kiwi.png') as above?

Copy link

ContributorAuthor

medaminezghalJul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Theuri is used byclient.read_resource(), so, I think it should be the full path.

Copy link

Contributor

DouweMJul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@medaminezghal The path passed toclient.read_resource() is handled by the MCP server, so I think it can really be anything

pydantic_ai_slim/pydantic_ai/mcp.py

		)
		return self._get_content(resource)
		elif isinstance(part, mcp_types.ResourceLink):
		resource_result: mcp_types.ReadResourceResult = await self._client.read_resource(part.uri)

Copy link

Contributor

DouweMJul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

To make this work in the tests, I think we need to register each resource URI in the test server using@mcp.resource like here:https://github.com/modelcontextprotocol/python-sdk#resources

Copy link

ContributorAuthor

medaminezghalJul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@DouweM I think this only can be done usingFASTMCP.

Copy link

Contributor

DouweMJul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@medaminezghal We are using FastMCP though?

https://github.com/pydantic/pydantic-ai/blob/main/tests/mcp_server.py#L5

Copy link

ContributorAuthor

medaminezghalJul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@DouweM I didn't understand where should I add the@mcp.resource.

Copy link

Contributor

DouweMJul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@medaminezghal In the sametests/mcp_server.py where you added the tools returningResourceLinks. When an MCP server tool returns a resource link with a URI, the client (Pydantic AI) can then ask the server for that resource by URI, so the tools and resource handlers should be implemented in the same place.

Merge branch 'main' into update-versins

5d05916

medaminezghal added7 commits

July 17, 2025 13:11

Revert change to cohere and fix mcp tests naming

c23076d

Some fixes

e0e8369

Merge branch 'main' into update-versins

2289561

Update product_name.txt

8f4f718

Update test_mcp.py

7a985a6

Add compatibility with opentelemtry-api>=1.35

bd9856e

Merge branch 'main' into update-versins

0f0c9de

Labels

awaiting author revision

2 participants

Movatterモバイル変換

Update tests to be compatible with new OpenAI, MistralAI and MCP versions#2094

Are you sure you want to change the base?

Update tests to be compatible with new OpenAI, MistralAI and MCP versions#2094

Conversation

medaminezghal commentedJun 28, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

hyperlint-aibot commentedJun 28, 2025

PR Change Summary

Uh oh!

Uh oh!

DouweM left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DouweM commentedJul 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

medaminezghal commentedJul 9, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

DouweM commentedJul 9, 2025

Uh oh!

medaminezghal commentedJul 9, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

DouweM commentedJul 9, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

medaminezghal commentedJul 9, 2025

Uh oh!

DouweM commentedJul 9, 2025

Uh oh!

medaminezghal commentedJul 10, 2025

Uh oh!

DouweM left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

medaminezghal commentedJun 28, 2025•
edited
Loading

medaminezghal commentedJul 9, 2025•
edited
Loading

medaminezghal commentedJul 9, 2025•
edited
Loading

DouweM commentedJul 9, 2025•
edited
Loading