Hello@DouweM, as agreed inPR#1761, here is the new PR.

@davide-andreoli Thanks! Can you please have a look at the failing tests, and also implement this in the newmodels/google.py (assuming it makes sense there as well)?

@DouweM The test failures are due to the vendor_details field.
Since gemini tests are configured to always send afinish_reason (which makes sense, as it's a non-optional field in the response) the vendor_details field is awlays present in the GeminiModelResponses.
However, the snapshot comparison fails because vendor_details is marked withrepr=False in theModelResponse class.

I see two potential ways to address this:

1. Removerepr=False from thevendor_details field in theModelResponse class. This would be the cleanest solution, but I want to make sure it doesn't go against the original design intent
2. Update the tests to excludevendor_details before performing snapshot comparisons. This is a bit less elegant but still effective

Please let me know which approach you’d prefer.

And sure, no problem with adding the fields tomodels/google.py as well.

@davide-andreoli I had a chat about this with@dmontagu and we decided to make it so that dataclass fields with default values are excluded from reps:#1812. So once that merges (should be soon), you can merge/rebase, dropreps=False fromvendor_details and hopefully it won't require too many examples to be updated!

Hello@DouweM, work is done and tests are passing.
As agreed I removedrepr=False fromvendor_details and added the fields inmodels/google.py as well.

@davide-andreoli Thanks Davide!