Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.2k
Turn on validation for base64 decoding of Base64Bytes.#12048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
rjpower wants to merge3 commits intopydantic:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Without this, passing a raw byte array to a Base64Bytes field results in allbytes out of the base64 set being _silently_ dropped by base64.b64encode. Thisdoesn't seem like what we want in general and always makes me nervous aboutwhether I'm setting the fields correctly: setting a Base64Bytes field directlydoesn't trigger this behavior.This is technically breaking if someone was relying on the silent omit behavior.
codspeed-hqbot commentedJul 9, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
CodSpeed Performance ReportMerging#12048 willnot alter performanceComparing Summary
|
Coverage reportClick to see where and how coverage changed
This report was generated bypython-coverage-comment-action | ||||||||||||||||||||||||
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Turn on base64 validation for the Base64Bytes type.
Without this, passing a raw byte array to a Base64Bytes field results in all bytes out of the base64 set beingsilently dropped by base64.b64encode. This doesn't seem like what we want in general and always makes me nervous about whether I'm setting the fields correctly: setting a Base64Bytes field directly doesn't trigger this behavior.
This is technically breaking if someone was relying on the silent omission, but that seems dangerous at best.
fix#12047
Checklist