Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.2k
AddUNSET
sentinel#11883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Viicos wants to merge2 commits intomainChoose a base branch fromunset-sentinel
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
AddUNSET
sentinel#11883
+92 −122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Coverage reportClick to see where and how coverage changed
This report was generated bypython-coverage-comment-action |
I could imagine users might want custom sentinels too, should there be a generic "sentinel" schema? |
1 task
cloudflare-workers-and-pagesbot commentedJul 1, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Change Summary
Requirespydantic/pydantic-core#1711.
Example:
Things to consider:
UNSET
seems to be the best fit (andmatchesmsgspec
), but will be confusing as we already have a concept of unset fields (tracked in__pydantic_fields_set__
). These unset fields can already be excluded by specifyingexclude_unset=True
during serialization. If users explicitly setexclude_unset=False
but theUNSET
sentinel is still excluded, this will be confusing. One alternative could beMISSING
: it also makes it a little bit clearer that the expected behavior is to have fields set toMISSING
excluded from the output.pydantic-core
, but we need to expose it from theexperimental
module as we rely on the draftPEP 661.UNSET
sentinel? I'm currently using a'literal'
schema, but not ideal for a couple reasons:'literal'
schemas together (e.g.Literal[1] | UNSET
->Literal[1, UNSET]
), we would need to account for this in the JSON Schema generation logic).