Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix issue with recursive generic models#11775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DouweM merged 2 commits intomainfromrecursive-gen
Apr 28, 2025
Merged

Fix issue with recursive generic models#11775

DouweM merged 2 commits intomainfromrecursive-gen
Apr 28, 2025

Conversation

Viicos
Copy link
Member

Change Summary

Fixes#11748. Although this bug was present since v2.0, it manifested in a hard failure since 2.11, so we'll backport it.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

leonardzou reacted with hooray emojileonardzou reacted with rocket emoji
@ViicosViicos added backport-2.11Needs backport to 2.11 relnotes-fixUsed for bugfixes. third-party-testsAdd this label on a PR to trigger 3rd party tests labelsApr 18, 2025
@ViicosViicos closed thisApr 18, 2025
@ViicosViicos reopened thisApr 18, 2025
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedApr 18, 2025•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:eda3702
Status: ✅  Deploy successful!
Preview URL:https://815726a0.pydantic-docs.pages.dev
Branch Preview URL:https://recursive-gen.pydantic-docs.pages.dev

View logs

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedApr 18, 2025•
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic/_internal
  _generate_schema.py
Project Total 

This report was generated bypython-coverage-comment-action

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedApr 18, 2025•
edited
Loading

CodSpeed Performance Report

Merging#11775 willnot alter performance

Comparingrecursive-gen (eda3702) withmain (bf06866)

Summary

✅ 46 untouched benchmarks

@DouweMDouweM merged commit455b436 intomainApr 28, 2025
89 checks passed
@DouweMDouweM deleted the recursive-gen branchApril 28, 2025 18:53
Viicos added a commit that referenced this pull requestApr 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@DouweMDouweMDouweM approved these changes

Assignees

@ViicosViicos

Labels
backport-2.11Needs backport to 2.11relnotes-fixUsed for bugfixes.third-party-testsAdd this label on a PR to trigger 3rd party tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RootModel with Generics with self-referencing fails to compile
2 participants
@Viicos@DouweM
[8]ページ先頭
©2009-2025 Movatter.jp