Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix crash when expanding root type in the mypy plugin#11735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 1 commit intomainfromroot-type-fw-ref
Apr 17, 2025

Conversation

Viicos
Copy link
Member

Change Summary

Fixes#11727.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelApr 11, 2025
@ViicosViicos added the backport-2.11Needs backport to 2.11 labelApr 11, 2025
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedApr 11, 2025•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:16d112c
Status: ✅  Deploy successful!
Preview URL:https://852d7a4a.pydantic-docs.pages.dev
Branch Preview URL:https://root-type-fw-ref.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedApr 11, 2025•
edited
Loading

CodSpeed Performance Report

Merging#11735 willnot alter performance

Comparingroot-type-fw-ref (16d112c) withmain (2e7cddb)

Summary

✅ 46 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedApr 11, 2025•
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  mypy.py345
Project Total 

This report was generated bypython-coverage-comment-action

Copy link
Contributor

@dmontagudmontagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

no idea what's going on but this seems safe enough

@Viicos
Copy link
MemberAuthor

no idea what's going on but this seems safe enough

Not entirely sure either, this happens with forward references but my mypy knowledge is too limited to understand how they do it for stdlib dataclasses..

@ViicosViicos merged commitc477e46 intomainApr 17, 2025
62 checks passed
@ViicosViicos deleted the root-type-fw-ref branchApril 17, 2025 16:31
Viicos added a commit that referenced this pull requestApr 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dmontagudmontagudmontagu approved these changes

Assignees
No one assigned
Labels
backport-2.11Needs backport to 2.11relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception in mypy plugin with type alias, root model and forward reference
2 participants
@Viicos@dmontagu
[8]ページ先頭
©2009-2025 Movatter.jp