Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.2k
Provide the available definitions when applying discriminated unions#11670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
It seems that we forgot to do so, and as almost all discriminated unionsinvolves referenceable schemas (such as models, typed dicts, etc), thedeferred metadata key was almost always set.This fixes some issues in the schema cleaning process, although it isstill theoretically unsound (see the added tests).
Deploying pydantic-docs with |
| Latest commit: | 3fe195a |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eaedca80.pydantic-docs.pages.dev |
| Branch Preview URL: | https://discriminator-defs.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging#11670 willnot alter performanceComparing Summary
|
Coverage reportThis PR does not seem to contain any modification to coverable code. |
davidhewitt approved these changesApr 2, 2025
8b0825a intomain 88 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Viicos added a commit that referenced this pull requestApr 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
backport-2.11Needs backport to 2.11 relnotes-fixUsed for bugfixes. third-party-testsAdd this label on a PR to trigger 3rd party tests
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
It seems that we forgot to do so, and as almost all discriminated unions involves referenceable schemas (such as models, typed dicts, etc), the deferred metadata key was almost always set.
This fixes some issues in the schema cleaning process, although it is still theoretically unsound (see the added tests).
Fixes#11661.
Change Summary
Related issue number
Checklist