Warn if registering virtual subclasses on Pydantic models#11669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft

Viicos wants to merge1 commit intomain

base:main

Choose a base branch

Draft

Viicos wants to merge1 commit intomainfromabc-checks

Conversation

Copy link

Member

I'll wait for the outcome ofpython/cpython#131914 as we might be able to conditionally have this logic depending on the Python version.

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Warn if registering virtual subclasses on Pydantic models

dd1bee6

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Copy link

_{Comparingabc-checks (dd1bee6) withmain (6c38dc9)}

⚡ 6 improvements
✅ 40 untouched benchmarks

	Benchmark	`BASE`	`HEAD`	Change
⚡	`test_efficiency_with_highly_nested_examples`	696.3 µs	649.2 µs	+7.26%
⚡	`test_isinstance_basemodel`	26.7 ms	6.3 ms	×4.2
⚡	`test_list_of_models_validation[__init__]`	80.5 µs	76.4 µs	+5.39%
⚡	`test_list_of_models_validation[model_validate]`	78.7 µs	74.3 µs	+5.92%
⚡	`test_simple_model_validation[model_validate]`	40.8 µs	38.3 µs	+6.76%
⚡	`test_north_star_validate_python_strict`	22.7 ms	21.6 ms	+5.46%