Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Properly validate parameterized mappings#11658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 2 commits intomainfrommapping-regression
Apr 2, 2025
Merged

Conversation

Viicos
Copy link
Member

Change Summary

Fixes#11650.

Regression in#11247, the logic was somehow tweaked when moved to theGenerateSchema class, so it was restored to how it was before.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelMar 31, 2025
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedMar 31, 2025•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:a071a50
Status: ✅  Deploy successful!
Preview URL:https://36bb88bf.pydantic-docs.pages.dev
Branch Preview URL:https://mapping-regression.pydantic-docs.pages.dev

View logs

@ViicosViicos added the backport-2.11Needs backport to 2.11 labelMar 31, 2025
@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedMar 31, 2025•
edited
Loading

CodSpeed Performance Report

Merging#11658 willnot alter performance

Comparingmapping-regression (a071a50) withmain (dfa6c67)

Summary

✅ 46 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedMar 31, 2025•
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

@davidhewittdavidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM with one comment

Comment on lines 6957 to 6958
Note - we still don't do a good job of handling subclasses, as we convert the input to a dict
via the MappingValidator annotation's schema.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is this comment now out of date?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch -- well theMappingValidator is not a thing anymore but I think the comment is still relevant.

@ViicosViicosenabled auto-merge (squash)April 2, 2025 20:36
@ViicosViicos merged commit34095c7 intomainApr 2, 2025
60 checks passed
@ViicosViicos deleted the mapping-regression branchApril 2, 2025 20:48
Viicos added a commit that referenced this pull requestApr 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@davidhewittdavidhewittdavidhewitt approved these changes

Assignees
No one assigned
Labels
backport-2.11Needs backport to 2.11relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression 2.10: Not properly validating disjunction of dataclasses (or TypedDict) that embed Mapping
2 participants
@Viicos@davidhewitt
[8]ページ先頭
©2009-2025 Movatter.jp