Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix inaccurate docstring example in_BaseMultiHostUrl.query_params()#11611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Jeukoh
Copy link
Contributor

@JeukohJeukoh commentedMar 24, 2025•
edited by pydantic-hookybot
Loading

Change Summary

The previous docstring included a mismatched query example, which could cause confusion.
The updated docstring uses a corresponding return value to clearly demonstrate expected behavior.

Related issue number

N/A

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer:@sydney-runkle

@JeukohJeukohforce-pushed thedocs/query-params-in-MultiHostUrl branch from57b64f7 tob91a0e9CompareMarch 24, 2025 11:39
@Jeukoh
Copy link
ContributorAuthor

please review

pydantic-hooky[bot] reacted with thumbs up emoji

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedMar 24, 2025•
edited
Loading

CodSpeed Performance Report

Merging#11611 willnot alter performance

ComparingJeukoh:docs/query-params-in-MultiHostUrl (ed24646) withmain (8e98bc0)

Summary

✅ 46 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@ViicosViicos changed the titleFix inaccurate docstring example in _BaseMultiHostUrl.query_paramsFix inaccurate docstring example in_BaseMultiHostUrl.query_params()Mar 25, 2025
Copy link
Member

@ViicosViicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the fix

Jeukoh reacted with laugh emoji
@ViicosViicosenabled auto-merge (squash)March 25, 2025 13:38
@ViicosViicos added relnotes-ignoreOmit this PR from the release notes. and removed ready for review labelsMar 25, 2025
@ViicosViicos merged commit6433ea7 intopydantic:mainMar 25, 2025
59 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ViicosViicosViicos approved these changes

Assignees
No one assigned
Labels
documentationrelnotes-ignoreOmit this PR from the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Jeukoh@Viicos
[8]ページ先頭
©2009-2025 Movatter.jp