Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Suggest usingprop-decorator error code to ignore mypy errors with@computed_field#11547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 1 commit intopydantic:mainfromjoren485:mypy-prop-decorator
Mar 13, 2025

Conversation

joren485
Copy link
Contributor

@joren485joren485 commentedMar 13, 2025•
edited by pydantic-hookybot
Loading

Change Summary

For property decorators,# type: ignore[prop-decorator] is the correct type ignore comment in Mypy,# type: ignore[misc] should only be used for backward compatibly.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer:@sydney-runkle

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelMar 13, 2025
@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@joren485
Copy link
ContributorAuthor

please review

pydantic-hooky[bot] reacted with thumbs up emoji

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedMar 13, 2025•
edited
Loading

CodSpeed Performance Report

Merging#11547 willnot alter performance

Comparingjoren485:mypy-prop-decorator (e4c76e8) withmain (10af6a8)

Summary

✅ 46 untouched benchmarks

Copy link
Member

@ViicosViicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, let's not mention the backwards compatible code, users are strongly encouraged to update their type checker version.

@ViicosViicos added awaiting author responseawaiting response from issue opener and removed ready for review labelsMar 13, 2025
@ViicosViicos added relnotes-ignoreOmit this PR from the release notes. and removed relnotes-fixUsed for bugfixes. awaiting author responseawaiting response from issue opener labelsMar 13, 2025
@ViicosViicos changed the titleDocument the narrowest type ignore comment for property decoratorsSuggest usingprop-decorator error code to ignore mypy errors with@computed_fieldMar 13, 2025
@ViicosViicos merged commitb9fb3f1 intopydantic:mainMar 13, 2025
60 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ViicosViicosViicos approved these changes

Assignees
No one assigned
Labels
relnotes-ignoreOmit this PR from the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@joren485@Viicos
[8]ページ先頭
©2009-2025 Movatter.jp