Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add support for validating v6, v7, v8 UUIDs#11436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 4 commits intopydantic:mainfromastei:astei/add-uuid-v7
Feb 25, 2025

Conversation

astei
Copy link
Contributor

@asteiastei commentedFeb 13, 2025•
edited
Loading

First-time contributor. I think this change is still ultimately trivial, even though it also requires a change inpydantic-core too (since that's where the UUID validation logic lives).

Change Summary

Adds support for validating v6, v7, and v8 UUIDs. These versions are defined inRFC 9562. To pluck some really low-hanging fruit, implement support for it in pydantic.

Depends onpydantic/pydantic-core#1634 (UUIDv7),pydantic/pydantic-core#1636 (v6 / v8)

Related issue number

n/a

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer:@sydney-runkle

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelFeb 13, 2025
@astei
Copy link
ContributorAuthor

please review

pydantic-hooky[bot] reacted with thumbs up emoji

@astei
Copy link
ContributorAuthor

CI failures look to be expected due to the dependent pydantic-core change

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedFeb 13, 2025•
edited
Loading

CodSpeed Performance Report

Merging#11436 willnot alter performance

Comparingastei:astei/add-uuid-v7 (f533b69) withmain (c8acbec)

Summary

✅ 46 untouched benchmarks

@Viicos
Copy link
Member

Thanks for the contribution. Could we also add version 6 and 8?

@astei
Copy link
ContributorAuthor

@Viicos I'm happy to do so, but this will require an additional change inpydantic-core. Will submit another PR for that.

@Viicos
Copy link
Member

Thanks, that would be great.

@sydney-runkle
Copy link
Contributor

This looks great, thanks for the contribution!

@asteiastei changed the titleAdd support for validating v7 UUIDsAdd support for validating v6, v7, v8 UUIDsFeb 14, 2025
@astei
Copy link
ContributorAuthor

@sydney-runkle@Viicos

I have added the v6/v8 support, as well as openingpydantic/pydantic-core#1636 to add the required support withinpydantic-core.

@sydney-runkle
Copy link
Contributor

Perfect! When we do apydantic-core patch release later this week, I'll pull this in and get across the line. Thanks!

@sydney-runklesydney-runkle removed the awaiting author revisionawaiting changes from the PR author labelFeb 18, 2025
@sydney-runklesydney-runkle merged commite226612 intopydantic:mainFeb 25, 2025
22 of 50 checks passed
sydney-runkle added a commit that referenced this pull requestFeb 26, 2025
Co-authored-by: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees

@sydney-runklesydney-runkle

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@astei@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp