Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Properly support type variable defaults#11332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 2 commits intomainfromtypevar-defaults
Jan 24, 2025
Merged

Properly support type variable defaults#11332

Viicos merged 2 commits intomainfromtypevar-defaults
Jan 24, 2025

Conversation

Viicos
Copy link
Member

If a type argument isn't provided, use the default value.

Change Summary

Fixes#11270,closes#11297.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedJan 23, 2025•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:ec82c47
Status: ✅  Deploy successful!
Preview URL:https://a902f4a8.pydantic-docs.pages.dev
Branch Preview URL:https://typevar-defaults.pydantic-docs.pages.dev

View logs

If a type argument isn't provided, use the default value.
@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedJan 23, 2025•
edited
Loading

CodSpeed Performance Report

Merging#11332 willnot alter performance

Comparingtypevar-defaults (ec82c47) withmain (221275f)

Summary

✅ 45 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  main.py
  pydantic/_internal
  _generics.py
Project Total 

This report was generated bypython-coverage-comment-action

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Generally, looking good! Thanks for tackling this :)

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, it's more clear with the extra comment.

@ViicosViicos merged commitbe3b3c0 intomainJan 24, 2025
56 checks passed
@ViicosViicos deleted the typevar-defaults branchJanuary 24, 2025 14:55
@ViicosViicos added relnotes-feature and removed relnotes-fixUsed for bugfixes. labelsJan 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic type defaults (pep-696) throws an exception when used in type annotations.
2 participants
@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp