NotificationsYou must be signed in to change notification settings
Fork2.2k
Star24.6k

Add a`check_pydantic_core_version()` function#11324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Viicos merged 3 commits intomainfromcheck-pc-version

Jan 24, 2025

Merged

Add a`check_pydantic_core_version()` function#11324

Viicos merged 3 commits intomainfromcheck-pc-version

Jan 24, 2025

Conversation

Copy link

Member

Viicos commentedJan 23, 2025

Ensuring the correctpydantic-core version is installed.

Closes#11323.

Change Summary

Related issue number

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Add acheck_pydantic_core_version() function

6b8d54e

Ensuring the correct `pydantic-core` version is installed.

github-actionsbot added the relnotes-packagingUsed for dependency changes. label

Jan 23, 2025

Copy link

cloudflare-workers-and-pagesbot commentedJan 23, 2025•
edited
Loading

Deploying pydantic-docs with Cloudflare Pages

Latest commit:	`6d632ea`
Status:	✅ Deploy successful!
Preview URL:	https://6859aff4.pydantic-docs.pages.dev
Branch Preview URL:	https://check-pc-version.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hqbot commentedJan 23, 2025•
edited
Loading

CodSpeed Performance Report

Merging#11324 willnot alter performance

_{Comparingcheck-pc-version (6d632ea) withmain (221275f)}

Summary

✅ 45 untouched benchmarks

Copy link

Contributor

github-actionsbot commentedJan 23, 2025•
edited
Loading

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic
version.py
Project Total

_{This report was generated bypython-coverage-comment-action}

Merge branch 'main' into check-pc-version

ac36cae

sydney-runkle requested a review fromsamuelcolvin

January 24, 2025 01:30

samuelcolvin reviewed

Jan 24, 2025

View reviewed changes

Copy link

Member

samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We need a comment on pyproject.toml saying "you need to update this in xxx if you change it here."

pydantic/version.py OutdatedShow resolvedHide resolved

Feedback

6d632ea

sydney-runkle reviewed

Jan 24, 2025

View reviewed changes

pydantic/version.py

		@@ -63,6 +65,12 @@ def version_info() -> str:
		return '\n'.join('{:>30} {}'.format(k + ':', str(v).replace('\n', ' ')) for k, v in info.items())


		def check_pydantic_core_version() -> bool:
		"""Check that the installed `pydantic-core` dependency is compatible."""
		# Keep this in sync with the version constraint in the `pyproject.toml` dependencies: