Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add additional allowed schemes forClickHouseDsn#11319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 7 commits intopydantic:mainfromMaze21127:clickhousedsn-chemas
Jan 24, 2025

Conversation

Maze21127
Copy link
Contributor

@Maze21127Maze21127 commentedJan 22, 2025•
edited by pydantic-hookybot
Loading

Change Summary

allowed_schemes in ClickHouseDsn don't compability with base clickhouse schema, this PR fix it

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer:@sydney-runkle

AkiiraBino, 0xMihalich, Neko1313, flwd3m, Photon94, and Maze21127 reacted with thumbs up emojiAkiiraBino reacted with heart emojiAkiiraBino reacted with rocket emoji
@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelJan 22, 2025
@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedJan 22, 2025•
edited
Loading

CodSpeed Performance Report

Merging#11319 willnot alter performance

ComparingMaze21127:clickhousedsn-chemas (c56d6bd) withmain (221275f)

Summary

✅ 45 untouched benchmarks

@Maze21127
Copy link
ContributorAuthor

please review

pydantic-hooky[bot] reacted with thumbs up emoji

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedJan 23, 2025•
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

@ViicosViicos changed the titleAdd additional allowed schemas for ClickHouseDsnAdd additional allowed schemes forClickHouseDsnJan 23, 2025
@Viicos
Copy link
Member

Could you please provide info attesting thatclickhouses/clickhousedb are valid schemes?

@Maze21127
Copy link
ContributorAuthor

Could you please provide info attesting thatclickhouses/clickhousedb are valid schemes?

clickhouses - secure connection inclickhouse-driver

clickhousedb - uses inclickhouse-connect

Viicos reacted with thumbs up emoji

Copy link
Member

@ViicosViicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks

@ViicosViicosenabled auto-merge (squash)January 24, 2025 10:49
@ViicosViicosdisabled auto-mergeJanuary 24, 2025 10:49
@ViicosViicosenabled auto-merge (squash)January 24, 2025 10:49
@ViicosViicos merged commit192845d intopydantic:mainJan 24, 2025
52 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ViicosViicosViicos approved these changes

Assignees

@sydney-runklesydney-runkle

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Maze21127@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp