Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix JSON Schema reference collection with"examples" keys#11305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 1 commit intomainfrom11304
Jan 21, 2025

Conversation

Viicos
Copy link
Member

Change Summary

Fixes#11304.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

kujenga reacted with heart emoji
@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelJan 20, 2025
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedJan 20, 2025•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:3aa1e7b
Status: ✅  Deploy successful!
Preview URL:https://a12ccc8a.pydantic-docs.pages.dev
Branch Preview URL:https://11304.pydantic-docs.pages.dev

View logs

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  json_schema.py
Project Total 

This report was generated bypython-coverage-comment-action

@codspeed-hqCodSpeed HQ
Copy link

CodSpeed Performance Report

Merging#11305 willnot alter performance

Comparing11304 (3aa1e7b) withmain (968d64f)

Summary

✅ 45 untouched benchmarks

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good find, thanks for the quick fix.

@sydney-runklesydney-runkle merged commit8311d1a intomainJan 21, 2025
57 checks passed
@sydney-runklesydney-runkle deleted the 11304 branchJanuary 21, 2025 19:00
Viicos added a commit that referenced this pull requestJan 23, 2025
@kujenga
Copy link

Thanks for getting this in so quickly! Any guidance about when the next version will be released including this?

@Viicos
Copy link
MemberAuthor

@kujenga this is available in 2.10.6 which just got released.

kujenga reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeAdapter.json_schema produces invalid output when object has "examples" field after 2.9 to 2.10 upgrade
3 participants
@Viicos@kujenga@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp