Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Improve performance of_typing_extra module#11255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 2 commits intomainfromtyping-extra-perf
Jan 10, 2025
Merged

Conversation

Viicos
Copy link
Member

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelJan 10, 2025
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedJan 10, 2025•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:6f56712
Status: ✅  Deploy successful!
Preview URL:https://e27b80b8.pydantic-docs.pages.dev
Branch Preview URL:https://typing-extra-perf.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedJan 10, 2025•
edited
Loading

CodSpeed Performance Report

Merging#11255 willnot alter performance

Comparingtyping-extra-perf (6f56712) withmain (e9ff00c)

Summary

✅ 45 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedJan 10, 2025•
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic/_internal
  _typing_extra.py
Project Total 

This report was generated bypython-coverage-comment-action

@@ -58,7 +40,7 @@ def is_any(tp: Any, /) -> bool:
#> True
```
"""
return_is_typing_name(tp, name='Any')
returntp is typing.Any or tp is t_e.Any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wonder if it's worth importing everything by name and avoiding the attribute access, in my test it reduced the time from about 30ns to 20ns?

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking great otherwise!

@sydney-runklesydney-runkle added relnotes-performanceUsed for performance improvements. and removed relnotes-fixUsed for bugfixes. labelsJan 10, 2025
@ViicosViicos merged commit8ef33a0 intomainJan 10, 2025
62 checks passed
@ViicosViicos deleted the typing-extra-perf branchJanuary 10, 2025 19:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@samuelcolvinsamuelcolvinsamuelcolvin left review comments

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-performanceUsed for performance improvements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Viicos@samuelcolvin@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp