One consequence here is slightly different behavior formaxlen being set fordeque types, but I think this is worth the significant simplification in internal logic we see here.

max_length constraints are still enforced, but we no longer monkeypatch themaxlen frommax_length on the deque. If users want this, they should write a custom validator.

I'll be writing an in depth explanation of changes in the changelog for v2.11 related to this PR sequence.

first pass at deque schema refactor

ece603d

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Jan 8, 2025

Copy link

codspeed-hqbot commentedJan 8, 2025•
edited
Loading

CodSpeed Performance Report

Merging#11239 willnot alter performance

_{Comparingremove-deq-prep-anns (34193ea) withmain (8fc509d)}

Summary

✅ 46 untouched benchmarks

fix test

c7e326c

Copy link

cloudflare-workers-and-pagesbot commentedJan 8, 2025•
edited
Loading

Deploying pydantic-docs with Cloudflare Pages

Latest commit:	`34193ea`
Status:	✅ Deploy successful!
Preview URL:	https://f9fb4ec4.pydantic-docs.pages.dev
Branch Preview URL:	https://remove-deq-prep-anns.pydantic-docs.pages.dev

View logs

sydney-runkle added third-party-testsAdd this label on a PR to trigger 3rd party tests and removed third-party-testsAdd this label on a PR to trigger 3rd party tests labels

Jan 8, 2025

Copy link

Contributor

github-actionsbot commentedJan 8, 2025•
edited
Loading

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic/_internal
_generate_schema.py
_validators.py
Project Total

_{This report was generated bypython-coverage-comment-action}

simplifying validator

34193ea

Copy link

ContributorAuthor

sydney-runkle commentedJan 9, 2025

cc@adriangb, more progress on simplifying logic here :)

No need for a review, but wanted to let you know.

sydney-runkle requested a review fromViicos

January 9, 2025 18:55

Viicos approved these changes

Jan 9, 2025

View reviewed changes

Copy link

Member

Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great

The fact that we can't access the metadata anymore to set themaxlen attribute shows a limitation of the current API, I'll maybe include it in my write up

Copy link

ContributorAuthor

sydney-runkle commentedJan 9, 2025

The fact that we can't access the metadata anymore to set the maxlen attribute shows a limitation of the current API, I'll maybe include it in my write up.

I'm not opposed to allowing metadata access, though this opens a can of worms in terms of consistency with annotation application.

sydney-runkle merged commit4e055d5 intomain

Jan 9, 2025

61 checks passed

sydney-runkle deleted the remove-deq-prep-anns branch

January 9, 2025 20:10

sydney-runkle mentioned this pull request

Jan 10, 2025

MoveMapping schema gen toGenerateSchema to complete removal ofprepare_annotations_for_known_type workaround#11247

Merged

Labels

relnotes-fix

Used for bugfixes.

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Move`deque` schema gen to`GenerateSchema` class#11239

Move`deque` schema gen to`GenerateSchema` class#11239

Uh oh!

Conversation

sydney-runkle commentedJan 8, 2025•
edited
Loading

Uh oh!

Uh oh!

codspeed-hqbot commentedJan 8, 2025•
edited
Loading

Uh oh!