Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix url serialization for unions#11233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 1 commit intov2.10-patchesfromadd-url-fix
Jan 8, 2025
Merged

Conversation

sydney-runkle
Copy link
Contributor

Cherry picking5d92c05

Specifically, we've made the serialization for url types more strict. If a non-url type is passed into the serializer, we raise an unexpected value warning instead of just blindly attempting to stringify the input. This results in more intuitive behavior for serializing unions with url types.
@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelJan 8, 2025
@sydney-runkle
Copy link
ContributorAuthor

Will merge pending tests passing.

@sydney-runklesydney-runkle merged commit6e585f9 intov2.10-patchesJan 8, 2025
52 checks passed
@sydney-runklesydney-runkle deleted the add-url-fix branchJanuary 8, 2025 16:06
@codspeed-hqCodSpeed HQ
Copy link

CodSpeed Performance Report

Merging#11233 willdegrade performances by 5.6%

Comparingadd-url-fix (5f1ecdc) withmain (5d92c05)

Summary

❌ 1 regressions
✅ 43 untouched benchmarks
⁉️ 2 dropped benchmarks

⚠️Please fix the performance issues oracknowledge them on CodSpeed.

Benchmarks breakdown

Benchmarkmainadd-url-fixChange
⁉️test_getattr53.9 µsN/AN/A
⁉️test_setattr85.9 µsN/AN/A
❌test_tagged_union_with_callable_discriminator_schema_generation1.8 ms1.9 ms-5.6%

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ViicosViicosViicos approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sydney-runkle@Viicos
[8]ページ先頭
©2009-2025 Movatter.jp