Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add discriminated union related metadata entries to theCoreMetadata definition#11216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 1 commit intomainfromdiscriminated-union-meta-typed
Jan 7, 2025

Conversation

Viicos
Copy link
Member

From#10655.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelJan 3, 2025
@cloudflare-workers-and-pagesCloudflare Workers and Pages

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:de894e3
Status: ✅  Deploy successful!
Preview URL:https://760627cb.pydantic-docs.pages.dev
Branch Preview URL:https://discriminated-union-meta-typ.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

CodSpeed Performance Report

Merging#11216 willnot alter performance

Comparingdiscriminated-union-meta-typed (de894e3) withmain (aa85c3a)

Summary

✅ 46 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  types.py
  pydantic/_internal
  _core_metadata.py
  _discriminated_union.py
  _generate_schema.py
Project Total 

This report was generated bypython-coverage-comment-action

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yep, this makes sense.

I would love to not have to apply discriminators after schema build, but I don't think we know of a great way around that for now.

This is more consistent with the metadata pattern we currently use elsewhere, at least.

Would also love to have another discussion about moving thatmetadata structure topydantic-core so that we can avoid all of the internal casting...

@sydney-runklesydney-runkle merged commit9dc7d0b intomainJan 7, 2025
62 checks passed
@sydney-runklesydney-runkle deleted the discriminated-union-meta-typed branchJanuary 7, 2025 14:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp