NotificationsYou must be signed in to change notification settings
Fork2.2k
Star24.6k

Support initializing root model fields with values of the`root` type in the mypy plugin#11212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Viicos merged 1 commit intomainfromroot-model-plugin

Jan 8, 2025

Merged

Support initializing root model fields with values of the`root` type in the mypy plugin#11212

Viicos merged 1 commit intomainfromroot-model-plugin

Jan 8, 2025

Conversation

Copy link

Member

Viicos commentedJan 3, 2025

Also use theTypeInfo.has_base method instead of iterating over the MRO in various places.

Closes#11203.

Change Summary

Related issue number

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Support initializing root model fields with values of theroot type…

9dd8b0a

… in the mypy pluginAlso use the `TypeInfo.has_base` method instead of iterating over the MROin various places.

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Jan 3, 2025

Copy link

cloudflare-workers-and-pagesbot commentedJan 3, 2025

Deploying pydantic-docs with Cloudflare Pages

Latest commit:	`9dd8b0a`
Status:	✅ Deploy successful!
Preview URL:	https://37172f3c.pydantic-docs.pages.dev
Branch Preview URL:	https://root-model-plugin.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hqbot commentedJan 3, 2025

CodSpeed Performance Report

Merging#11212 willnot alter performance

_{Comparingroot-model-plugin (9dd8b0a) withmain (aa85c3a)}

Summary

✅ 46 untouched benchmarks

Copy link

Contributor

github-actionsbot commentedJan 3, 2025

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic
mypy.py
Project Total

_{This report was generated bypython-coverage-comment-action}

sydney-runkle approved these changes

Jan 7, 2025

View reviewed changes

Copy link

Contributor

sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This LGTM overall (thanks for adding the tests, those made the impact here quite clear), but let's have@dmontagu take a look as well given his familiarity with themypy plugin.

dmontagu approved these changes

Jan 8, 2025

View reviewed changes

Viicos merged commitbfeca9b intomain

Jan 8, 2025

62 checks passed

Viicos deleted the root-model-plugin branch

January 8, 2025 16:02

Copy link

antoniogamizdelgado commentedMar 31, 2025

Hello! We have started noticing these errors:

monolith/records2/company_definition/domain/badger_object/fields/field_error.py:26: error: Item "str" of "FieldName | str" has no attribute "root"  [union-attr]

Can this change be the cause of these new error? It was working fine last week.