Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.2k
Add pandera third-party tests#11193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cloudflare-workers-and-pagesbot commentedDec 30, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Deploying pydantic-docs with |
| Latest commit: | edc8fd4 |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d8a7ef95.pydantic-docs.pages.dev |
| Branch Preview URL: | https://pandera-ci.pydantic-docs.pages.dev |
codspeed-hqbot commentedDec 30, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
CodSpeed Performance ReportMerging#11193 willdegrade performances by 5.78%Comparing Summary
Benchmarks breakdown
|
Coverage reportThis PR does not seem to contain any modification to coverable code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, just some questions about our general structure for this test file.
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ['3.8', '3.9', '3.10', '3.11'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No 3.12?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems like they are lagging behind Python versions..
| # Instructions: | ||
| # - The CI should be as close as possible to the original project's workflows. | ||
| # - Use the checkout action to clone Pydantic with a custom path (e.g. `path: pydantic-latest`). | ||
| # - Make sure Pydantic is installed in editable mode (e.g. `uv pip install -e ./pydantic-latest`) | ||
| # so that the path appears in the `pip list` output (and so we can be assured Pydantic was properly | ||
| # installed from the provided path). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good to add these here. There's so much redundancy across jobs, maybe we could consolidate with shared logic for installing pydantic and settings things up...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The thing is each library depends on different tools: pip, uv, pdm, etc so having things consolidated is quite hard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice, thanks!
4332d8f intomainUh oh!
There was an error while loading.Please reload this page.
Change Summary
Part of#11160.
Related issue number
Checklist