NotificationsYou must be signed in to change notification settings
Fork2.2k
Star24.6k

Properly support PEP 695 generics syntax#11189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Viicos merged 5 commits intomainfrompep695-support

Dec 30, 2024

Merged

Properly support PEP 695 generics syntax#11189

Viicos merged 5 commits intomainfrompep695-support

Dec 30, 2024

Conversation

Copy link

Member

Viicos commentedDec 30, 2024•
edited
Loading

Best reviewed commit per commit.

Reword relevant docstrings and comments.

Fixes#11031.
Fixes#9782.

Change Summary

Related issue number

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Properly support PEP 695 generics syntax

f4bca87

Reword relevant docstrings and comments.

Copy link

cloudflare-workers-and-pagesbot commentedDec 30, 2024•
edited
Loading

Deploying pydantic-docs with Cloudflare Pages

Latest commit:	`308670a`
Status:	✅ Deploy successful!
Preview URL:	https://bea518c3.pydantic-docs.pages.dev
Branch Preview URL:	https://pep695-support.pydantic-docs.pages.dev

View logs

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Dec 30, 2024

Remove bad test, rewritetest_module_ns_is_none test

d49596c

It was added for coverage purposes, but is fragile becauseit tests the implementation, not the functionality. As aconsequence, it broke with the added logic in`parent_frame_namespace`.`test_module_ns_is_none` was rewritten to be self-contained.