NotificationsYou must be signed in to change notification settings
Fork2.2k
Star24.6k

Improve annotation application performance#11186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sydney-runkle merged 1 commit intomainfromann-application-perf-test

Dec 30, 2024

Merged

Improve annotation application performance#11186

sydney-runkle merged 1 commit intomainfromann-application-perf-test

Dec 30, 2024

Conversation

Copy link

Member

Change Summary

Related issue number

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Improve annotation application performance

d285728

Also remove unnecessary schema copy.

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Dec 28, 2024

Copy link

cloudflare-workers-and-pagesbot commentedDec 28, 2024

Deploying pydantic-docs with Cloudflare Pages

Latest commit:	`d285728`
Status:	✅ Deploy successful!
Preview URL:	https://d7bfb8e4.pydantic-docs.pages.dev
Branch Preview URL:	https://ann-application-perf-test.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hqbot commentedDec 28, 2024

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic/_internal
_generate_schema.py
Project Total

_{This report was generated bypython-coverage-comment-action}

Viicos commented

Dec 29, 2024

View reviewed changes

pydantic/_internal/_generate_schema.py

		@@ -2106,7 +2106,7 @@ def _apply_single_annotation(self, schema: core_schema.CoreSchema, metadata: Any
		return self.defs.definitions[new_ref]
		schema['ref'] = new_ref # type: ignore

		maybe_updated_schema = _known_annotated_metadata.apply_known_metadata(metadata, schema.copy())
		maybe_updated_schema = _known_annotated_metadata.apply_known_metadata(metadata, schema)

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

apply_known_metadata already copiesschema

Viicos commented

Dec 29, 2024

View reviewed changes

pydantic/_internal/_generate_schema.py

Comment on lines +2143 to +2145

		schema = get_inner_schema(source)
		schema = self._apply_single_annotation(schema, annotation)
		schema = self._apply_single_annotation_json_schema(schema, annotation)

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This way, we don't go through_appy_single_annotation* for annotations with a custom__get_pydantic_core_schema__ as it is unnecessary.

Viicos marked this pull request as ready for review

December 29, 2024 15:42

Copy link

MemberAuthor

Viicos commentedDec 29, 2024•
edited
Loading

This mostly improves performance fortest_field_validators_serializers (which is ignored in codspeed), or for any similar use case where annotations with a custom__get_pydantic_core_schema__ method is used: