Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove custom MRO implementation of Pydantic models#11184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 1 commit intomainfromrevert-mro
Dec 30, 2024

Conversation

Viicos
Copy link
Member

This is no longer necessary since#10666 was introduced.

Fixes#11183.
Fixes#11042.
Closes#11037.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

kc0506 and mike-optifino reacted with thumbs up emoji
This is no longer necessary since#10666was introduced.
@cloudflare-workers-and-pagesCloudflare Workers and Pages

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:6adc9c3
Status: ✅  Deploy successful!
Preview URL:https://6df86b72.pydantic-docs.pages.dev
Branch Preview URL:https://revert-mro.pydantic-docs.pages.dev

View logs

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelDec 27, 2024
@Viicos
Copy link
MemberAuthor

I believe this should be backported, as it fixes#11042 which was a regression.

sydney-runkle reacted with thumbs up emoji

@sydney-runkle
Copy link
Contributor

Generally, I approve of this approach, as discussed in#10666. I think that the less we can manipulate the MRO, the better, as it introduces a pretty complex internal pattern that's hard to maintain.

That being said, I think we should get buy in from@kc0506 and@dmontagu, as they were pretty involved in the addition of this custom MRO implementation.

Happy to do another patch 2.10 release with this fix, I've added the corresponding label.

@codspeed-hqCodSpeed HQ
Copy link

CodSpeed Performance Report

Merging#11184 willnot alter performance

Comparingrevert-mro (6adc9c3) withmain (fac2bfd)

Summary

✅ 46 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _model_construction.py
Project Total 

This report was generated bypython-coverage-comment-action

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Reviewed again, given that this is basically just a reversion, I think we can go ahead and merge.

@sydney-runklesydney-runkle merged commit54412ae intomainDec 30, 2024
58 checks passed
@sydney-runklesydney-runkle deleted the revert-mro branchDecember 30, 2024 15:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation of parametrized generics issues Regression using regex_engine python-re in pydantic >= 2.10b1
2 participants
@Viicos@sydney-runkle

[8]ページ先頭

©2009-2025 Movatter.jp