Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Includeopenapi-python-client check in issue creation for third-party failures, usemain branch#11182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 2 commits intomainfromopenai-check
Dec 27, 2024

Conversation

sydney-runkle
Copy link
Contributor

@sydney-runklesydney-runkle commentedDec 27, 2024•
edited
Loading

Follow up to#11171

Update the issue creation to include case where openapi tests fail, and update branch pointer.

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelDec 27, 2024
@sydney-runklesydney-runkle changed the titleCI: open issue for openai third party test failuresCI: open issue for openapi third party test failuresDec 27, 2024
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedDec 27, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:9c5ec7e
Status: ✅  Deploy successful!
Preview URL:https://72ad6d94.pydantic-docs.pages.dev
Branch Preview URL:https://openai-check.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedDec 27, 2024•
edited
Loading

CodSpeed Performance Report

Merging#11182 willnot alter performance

Comparingopenai-check (9c5ec7e) withmain (fac2bfd)

Summary

✅ 46 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@ViicosViicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, could you also update the checked out repo? My PR was merged since then.

sydney-runkle reacted with thumbs up emoji
@sydney-runklesydney-runkle added the third-party-testsAdd this label on a PR to trigger 3rd party tests labelDec 27, 2024
@sydney-runkle
Copy link
ContributorAuthor

sydney-runkle commentedDec 27, 2024•
edited
Loading

Manually triggered the workflow here to confirm things are working:https://github.com/pydantic/pydantic/actions/runs/12518334387, as I addedthird-party-tests after pushing.

In a future PR we could make this workflow trigger on a label change as well, though that's low priority.

@sydney-runklesydney-runkleenabled auto-merge (squash)December 27, 2024 16:50
@ViicosViicos changed the titleCI: open issue for openapi third party test failuresIncludeopenapi-python-client check in issue creation for third-party failures, usemain branchDec 27, 2024
@sydney-runklesydney-runkle merged commitdaa0732 intomainDec 27, 2024
73 checks passed
@sydney-runklesydney-runkle deleted the openai-check branchDecember 27, 2024 17:25
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ViicosViicosViicos approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.third-party-testsAdd this label on a PR to trigger 3rd party tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sydney-runkle@Viicos
[8]ページ先頭
©2009-2025 Movatter.jp