Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Raise a deprecation warning when a field is annotated as final with a default value#11168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 2 commits intomainfrom11119-1
Dec 27, 2024

Conversation

Viicos
Copy link
Member

Also adapt thecollect_model_fields logic a bit.

Part of#11119.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@ViicosViicos changed the titleRaise a deprecation warning when a field is annotated as final with a…Raise a deprecation warning when a field is annotated as final with a default valutDec 21, 2024
@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelDec 21, 2024
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedDec 21, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:d4fc9f1
Status: ✅  Deploy successful!
Preview URL:https://f378e618.pydantic-docs.pages.dev
Branch Preview URL:https://11119-1.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedDec 21, 2024•
edited
Loading

CodSpeed Performance Report

Merging#11168 willnot alter performance

Comparing11119-1 (d4fc9f1) withmain (b236291)

Summary

✅ 46 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedDec 21, 2024•
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  warnings.py
  pydantic/_internal
  _fields.py
Project Total 

This report was generated bypython-coverage-comment-action

@ViicosViicos changed the titleRaise a deprecation warning when a field is annotated as final with a default valutRaise a deprecation warning when a field is annotated as final with a default valueDec 21, 2024
… default valueAlso adapt the `collect_model_fields` logic a bit.
@ViicosViicos added relnotes-changeUsed for changes to existing functionality which don't have a better categorization. and removed relnotes-fixUsed for bugfixes. labelsDec 23, 2024
Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work on the refactor usingassigned_value instead of re-fetching depending on the branch you hit.

LGTM overall, I left a few minor change requests.

@pydantic-hookypydantic-hookybot added the awaiting author revisionawaiting changes from the PR author labelDec 27, 2024
@sydney-runkle
Copy link
Contributor

Do we know why we treated finalvars with defaults as classvars in the past?

@Viicos
Copy link
MemberAuthor

Do we know why we treated finalvars with defaults as classvars in the past?

As perthe PR that implemented this:

Implementation is based on aPEP 591:

Type checkers should infer a final attribute that is initialized in a class body as being a class variable.

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Feedback looks good

@sydney-runklesydney-runkle merged commitd823d8c intomainDec 27, 2024
58 checks passed
@sydney-runklesydney-runkle deleted the 11119-1 branchDecember 27, 2024 18:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees

@ViicosViicos

Labels
awaiting author revisionawaiting changes from the PR authorrelnotes-changeUsed for changes to existing functionality which don't have a better categorization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp