NotificationsYou must be signed in to change notification settings
Fork2.2k
Star24.6k

Move FastAPI tests to third-party workflow#11164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sydney-runkle merged 1 commit intomainfromadapt-fastapi-ci

Dec 20, 2024

Merged

Move FastAPI tests to third-party workflow#11164

sydney-runkle merged 1 commit intomainfromadapt-fastapi-ci

Dec 20, 2024

Conversation

Copy link

Member

Change Summary

Part of#11160

Related issue number

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Dec 20, 2024

Copy link

cloudflare-workers-and-pagesbot commentedDec 20, 2024•
edited
Loading

Deploying pydantic-docs with Cloudflare Pages

Latest commit:	`bfc2efb`
Status:	✅ Deploy successful!
Preview URL:	https://ccab206e.pydantic-docs.pages.dev
Branch Preview URL:	https://adapt-fastapi-ci.pydantic-docs.pages.dev

View logs

Viicos mentioned this pull request

Dec 20, 2024

Add third-party CI tests#11160

Open

16 tasks

Viicos commented

Dec 20, 2024

View reviewed changes

tests/test_fastapi.sh

Comment on lines -18 to -23

		# This may be necessary if we make low-consequence changes to pydantic, such as minor changes the details of a JSON
		# schema or the contents of a ValidationError
		#
		# To skip a specific test, add '--deselect path/to/test.py::test_name' to the end of this command
		#
		# To update the list of deselected tests, remove all deselections, run the tests, and re-add any remaining failures

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Note that we loose the ability to skip failing tests. But thepytest command that we run in the third-party workflow can still be adapted to deselect tests.

And more generally, it might be that we get failing third-party tests if themain branch of the projects we test is broken. If this happens too often, we can checkout a specific revision instead (but we'll have to remind ourselves to update the revision regularly).