NotificationsYou must be signed in to change notification settings
Fork2.2k
Star24.6k

Override`subclasscheck` on`ModelMetaclass` to avoid memory leak and performance issues#11116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sydney-runkle merged 1 commit intomainfromsubclasscheck

Dec 16, 2024

Merged

Override`subclasscheck` on`ModelMetaclass` to avoid memory leak and performance issues#11116

sydney-runkle merged 1 commit intomainfromsubclasscheck

Dec 16, 2024

Conversation

Copy link

Member

Viicos commentedDec 15, 2024•
edited
Loading

We avoid relying onABCMeta.__subclasscheck__ unless we're pretty sure. Note that this was wrongly addressed as__instancecheck__ was implemented instead of__subclasscheck__. However, it is not clear if implementing__instancecheck__ fixed existing issues as well, so it is left as is.

Also changed the checked attribute to__pydantic_decorators__, as this is one of the first attributes being set on the class, and it might be that we change the way__pydantic_validator__ is set in the future (e.g. whendefer_build is set, and if we don't implement mock validators anymore).

Fixes#11100.

Change Summary

Related issue number

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Override__subclasscheck__ onModelMetaclass to avoid memory leak…

1922dfe

… and performance issuesWe avoid relying on `ABCMeta.__subclasscheck__` unless we're pretty sure.Note that this was wrongly addressed as `__instancecheck__` was implementedinstead of `__subclasscheck__`. However, it is not clear if implementing`__instancecheck__` fixed existing issues as well, so it is left as is.Also changed the checked attribute to `__pydantic_decorators__`, asthis is one of the first attributes being set on the class, and itmight be that we change the way `__pydantic_validator__` is set inthe future (e.g. when `defer_build` is set, and if we don't implementmock validators anymore).

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Dec 15, 2024

Copy link

cloudflare-workers-and-pagesbot commentedDec 15, 2024

Deploying pydantic-docs with Cloudflare Pages

Latest commit:	`1922dfe`
Status:	✅ Deploy successful!
Preview URL:	https://41a7f040.pydantic-docs.pages.dev
Branch Preview URL:	https://subclasscheck.pydantic-docs.pages.dev

View logs