NotificationsYou must be signed in to change notification settings
Fork2.2k
Star24.6k

Recursively unpack`Literal` values if using PEP 695 type aliases#11114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sydney-runkle merged 1 commit intomainfromliteral-type-aliases

Dec 16, 2024

Merged

Recursively unpack`Literal` values if using PEP 695 type aliases#11114

sydney-runkle merged 1 commit intomainfromliteral-type-aliases

Dec 16, 2024

Conversation

Copy link

Member

Change Summary

Fixes#9269.

Related issue number

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Dec 14, 2024

Copy link

cloudflare-workers-and-pagesbot commentedDec 14, 2024•
edited
Loading

Deploying pydantic-docs with Cloudflare Pages

Latest commit:	`fde4552`
Status:	✅ Deploy successful!
Preview URL:	https://76e0a2d4.pydantic-docs.pages.dev
Branch Preview URL:	https://literal-type-aliases.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hqbot commentedDec 14, 2024•
edited
Loading

CodSpeed Performance Report

Merging#11114 willnot alter performance

_{Comparingliteral-type-aliases (fde4552) withmain (17b1038)}

Summary

✅ 46 untouched benchmarks

Copy link

Contributor

github-actionsbot commentedDec 14, 2024

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic/_internal
_typing_extra.py
Project Total

_{This report was generated bypython-coverage-comment-action}

sydney-runkle approved these changes

Dec 16, 2024

View reviewed changes

Copy link

Contributor

sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work, thanks!!

pydantic/_internal/_typing_extra.py Outdated

		# Note: we could also check for generic aliases with a type alias as an origin.
		# However, it is very unlikely that this happens as type variables can't appear in
		# `Literal` forms, so the only valid (but unnecessary) use case would be something like:
		# `type Test[T] = Literal['a']` (and then use `Test[int]`).

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Did you mean to use a str literal here?

Copy link

MemberAuthor

ViicosDec 16, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, if you do:

typeTest[T]=Literal['whatever']MyLit=Literal[Test[int]]

MyLit.__args__[0] is aGenericAlias instance, and here we only check foris_type_alias_type. But as I mentioned in the comment it is very unlikely to encounter such use cases, as it is not necessary (the type variable is useless here as you can't do something liketype Test[T] = Literal[T]).