Add magic method to _BaseUrl class to support allowed usage of Field with max length with AnyUrl and simple length comparison and checks of AnyUrl types.

Related issue number

fix#11092

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer:@sydney-runkle

fix: add len to _BaseUrl to avoid TypeError

403ea9b

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Dec 13, 2024

Copy link

codspeed-hqbot commentedDec 13, 2024•
edited
Loading

CodSpeed Performance Report

Merging#11111 willnot alter performance

_{ComparingKharianne:add-len-baseurl (6149769) withmain (acc5902)}

Summary

✅ 46 untouched benchmarks

Copy link

Contributor

github-actionsbot commentedDec 13, 2024•
edited
Loading

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic
networks.py
Project Total

_{This report was generated bypython-coverage-comment-action}

Copy link

ContributorAuthor

Kharianne commentedDec 13, 2024

please review

pydantic-hookybot added the ready for review label

Dec 13, 2024

pydantic-hookybot assignedsydney-runkle

Dec 13, 2024

sydney-runkle suggested changes

Dec 16, 2024

View reviewed changes

Copy link

Contributor

sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

I think we can just tolen(self._url) in the__len__ check.

Could you also please add this fix to_BaseMultiHostUrl and add a test for that as well?

We'll get this into our patch release tomorrow :)

pydantic-hookybot added awaiting author revisionawaiting changes from the PR author and removed ready for review labels

Dec 16, 2024

pydantic-hookybot assignedKharianne and unassignedsydney-runkle

Dec 16, 2024

Copy link

ContributorAuthor

Kharianne commentedDec 16, 2024•
edited
Loading

@sydney-runkle

No problem! :-)
However your proposal does not work:
len(self._url) -->'pydantic_core._pydantic_core.Url' has no len()
That's why I needed to add the extra step to call the str method defined on _BaseUrl.

The self._url is a type Url from pydantic-core and this class is not of type Sized - not havinglen. Maybe this should be fixed in pydantic-core?

Edit: I added the fix to _BaseMultiHostUrl as well + test. But let me know if the fix should be here or in core.