Turns out discussion in#10484 (comment) was relevant, as not usingget_function_type_hints would skip theNone -> NoneType conversion, and other things might happen as well.

Change Summary

Related issue number

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Dec 11, 2024

Viicos commented

Dec 11, 2024

View reviewed changes

pydantic/_internal/_namespace_utils.py

		@@ -123,7 +125,11 @@ def ns_for_function(obj: Callable[..., Any], parent_namespace: MappingNamespace
		# passed as a separate argument. However, internally, `_eval_type` calls
		# `ForwardRef._evaluate` which will merge type params with the localns,
		# essentially mimicking what we do here.
		type_params: tuple[TypeVar, ...] = ()

Copy link

MemberAuthor

ViicosDec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I somehow forgot to actually fetch the type params here 🤔

Copy link

MemberAuthor

ViicosDec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Turns out the test did not use forward annotations, so it was fixed as well.

Copy link

codspeed-hqbot commentedDec 11, 2024•
edited
Loading

CodSpeed Performance Report

Merging#11093 willnot alter performance

_{Comparingvalidate-call-fixes (61e935d) withmain (6fa92d1)}

Summary

✅ 46 untouched benchmarks

Viicos force-pushed thevalidate-call-fixes branch fromd78f8b0 to80251ebCompare

December 12, 2024 10:51

Copy link

cloudflare-workers-and-pagesbot commentedDec 12, 2024•
edited
Loading

Deploying pydantic-docs with Cloudflare Pages

Latest commit:	`61e935d`
Status:	✅ Deploy successful!
Preview URL:	https://d47ea3e5.pydantic-docs.pages.dev
Branch Preview URL:	https://validate-call-fixes.pydantic-docs.pages.dev

View logs

This comment was marked as resolved.

Properly fetch PEP 695 type params for functions, do not fetch annota…

61e935d

…tions from signatureWe now unsupport built-in functions.

Viicos force-pushed thevalidate-call-fixes branch from80251eb to61e935dCompare

December 12, 2024 10:52

Viicos added the backport-2.10 label

Dec 12, 2024

Viicos marked this pull request as ready for review

December 12, 2024 10:56

Copy link

Contributor

github-actionsbot commentedDec 12, 2024

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic
validate_call_decorator.py
pydantic/_internal
_generate_schema.py
_namespace_utils.py
Project Total

_{This report was generated bypython-coverage-comment-action}

1 similar comment

Copy link

Contributor

github-actionsbot commentedDec 12, 2024

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic
validate_call_decorator.py
pydantic/_internal
_generate_schema.py
_namespace_utils.py
Project Total

_{This report was generated bypython-coverage-comment-action}

sydney-runkle approved these changes

Dec 12, 2024

View reviewed changes

Copy link

Contributor

sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking good overall, added a few follow up questions. Thanks!

pydantic/_internal/_generate_schema.py

		@@ -1832,13 +1832,7 @@ def _call_schema(self, function: ValidateCallSupportedTypes) -> core_schema.Call
		if p.annotation is sig.empty:
		annotation = typing.cast(Any, Any)
		else:
		# Note: This was originally get by `_typing_extra.get_function_type_hints`,
		# but we switch to simply `p.annotation` to support bultins (e.g. `sorted`).
		# May need to revisit if anything breaks.