Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix for comparison of AnyUrl objects#11082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 3 commits intopydantic:mainfromalexprabhat99:anyurl-comparison
Dec 11, 2024

Conversation

alexprabhat99
Copy link
Contributor

@alexprabhat99alexprabhat99 commentedDec 10, 2024•
edited by pydantic-hookybot
Loading

Change Summary

Related issue number

Fixes:#11069

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer:@sydney-runkle

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelDec 10, 2024
@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedDec 10, 2024•
edited
Loading

CodSpeed Performance Report

Merging#11082 willnot alter performance

Comparingalexprabhat99:anyurl-comparison (378035e) withmain (cc01258)

Summary

✅ 46 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedDec 10, 2024•
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  networks.py
Project Total 

This report was generated bypython-coverage-comment-action

@alexprabhat99
Copy link
ContributorAuthor

please review

pydantic-hooky[bot] reacted with thumbs up emoji

@sydney-runkle
Copy link
Contributor

Thanks for the PR! Could you please also implement__le__,__gt__, and__ge__ and add corresponding tests? Thanks!

@alexprabhat99
Copy link
ContributorAuthor

alexprabhat99 commentedDec 11, 2024•
edited
Loading

@sydney-runkle I have implemented__lt__,__gt__,__le__ and__ge__ and added corresponding tests. Thank you!

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great, thanks!

@sydney-runklesydney-runkle merged commit6fa92d1 intopydantic:mainDec 11, 2024
52 checks passed
@ViicosViicos changed the titleFix for comaparison of AnyUrl objectsFix for comparison of AnyUrl objectsJan 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees

@sydney-runklesydney-runkle

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comparison between AnyUrl objects is not working
2 participants
@alexprabhat99@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp