Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add FastAPI and SQLModel to third-party tests#11044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 28 commits intomainfromtesting-expeirment
Dec 20, 2024
Merged

Conversation

sydney-runkle
Copy link
Contributor

@sydney-runklesydney-runkle commentedDec 3, 2024•
edited by Viicos
Loading

Part of#11160.

zzstoatzz, desertaxle, and pleek91 reacted with heart emoji
@sydney-runklesydney-runkle added the third-party-testsAdd this label on a PR to trigger 3rd party tests labelDec 3, 2024
@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelDec 3, 2024
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedDec 3, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:ca343f7
Status: ✅  Deploy successful!
Preview URL:https://8f6ecfb5.pydantic-docs.pages.dev
Branch Preview URL:https://testing-expeirment.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedDec 3, 2024•
edited
Loading

CodSpeed Performance Report

Merging#11044 willnot alter performance

Comparingtesting-expeirment (ca343f7) withmain (7485725)

Summary

✅ 46 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedDec 3, 2024•
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

@ViicosViicos mentioned this pull requestDec 20, 2024
16 tasks
@ViicosViicos changed the titleWIP: test 3rd party packagesAdd FastAPI and SQLModel to third-party testsDec 20, 2024
@ViicosViicos added third-party-testsAdd this label on a PR to trigger 3rd party tests and removed third-party-testsAdd this label on a PR to trigger 3rd party tests labelsDec 20, 2024
@ViicosViicosforce-pushed thetesting-expeirment branch 5 times, most recently fromb7f1c40 to63136c7CompareDecember 20, 2024 11:29
Copy link
ContributorAuthor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great, thanks!

Screenshot 2024-12-20 at 10 38 48 AM

Note, re screenshot above - not sure if we need the ticks as it doesn't display as code on the actions list or actions drilldown.

Also, before we merge this PR, could we add a section tocontributing.md that explains our criteria / process for adding integration tests like this? Ex - # of starts, amount of usage, etc?

Copy link
Contributor

@hyperlint-aihyperlint-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

1 files reviewed, 1 total issue(s) found.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Mm]etaclass

Copy link
ContributorAuthor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, just a bit of workshoping on wording.


- The project is actively maintained.
- Making use of Pydantic internals (e.g. relying on the [`BaseModel`][pydantic.BaseModel] metaclass, typing utilities).
- The project is popular enough (although small projects can still be included depending on how Pydantic is being used).
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I feel like we should quantify this (some # of stars, downloads)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The thing is it really depends on how Pydantic is used. We can have project with 100k stars but if it is only defining simple models (e.g. models for an API client, and types are well contained) then there's no interest in testing it. On the other hand, a project with 200 stars defining complex custom types is more valuable. So it is hard to quantify :/

Co-authored-by: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com>
@ViicosViicosenabled auto-merge (squash)December 20, 2024 17:16
@ViicosViicosenabled auto-merge (squash)December 20, 2024 17:18
@ViicosViicos merged commitdebffa5 intomainDec 20, 2024
67 checks passed
@ViicosViicos deleted the testing-expeirment branchDecember 20, 2024 17:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hyperlint-aihyperlint-ai[bot]hyperlint-ai[bot] left review comments

@ViicosViicosViicos approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.third-party-testsAdd this label on a PR to trigger 3rd party tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sydney-runkle@Viicos
[8]ページ先頭
©2009-2025 Movatter.jp