Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Do not resolve the JSON Schema reference fordict core schema keys#10989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 1 commit intomainfromjs-dict-keys-ref
Dec 2, 2024

Conversation

Viicos
Copy link
Member

The referenced schema might not be available yet.

Fixes#10960.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelNov 27, 2024
@ViicosViicos mentioned this pull requestNov 27, 2024
36 tasks
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedNov 27, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:75ddc34
Status: ✅  Deploy successful!
Preview URL:https://ca106d21.pydantic-docs.pages.dev
Branch Preview URL:https://js-dict-keys-ref.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedNov 27, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10989 willnot alter performance

Comparingjs-dict-keys-ref (75ddc34) withmain (6f31f8f)

Summary

✅ 46 untouched benchmarks

The referenced schema might not be available yet.
@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  json_schema.py
Project Total 

This report was generated bypython-coverage-comment-action

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, thanks for the fix!

@sydney-runklesydney-runkle merged commitdd95071 intomainDec 2, 2024
54 checks passed
@sydney-runklesydney-runkle deleted the js-dict-keys-ref branchDecember 2, 2024 15:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem generating OpenAPI schema for models with an enum as the key of a dict
2 participants
@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp