Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Set fields whendefer_build is set on Pydantic dataclasses#10984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 1 commit intomainfromdataclass-defer-build-fields
Dec 2, 2024

Conversation

Viicos
Copy link
Member

This aligns with Pydantic models, where only the schema generation is deferred.

Also fix some comments.

Fixes#10953.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@cloudflare-workers-and-pagesCloudflare Workers and Pages

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:48ff78b
Status: ✅  Deploy successful!
Preview URL:https://278bde39.pydantic-docs.pages.dev
Branch Preview URL:https://dataclass-defer-build-fields.pydantic-docs.pages.dev

View logs

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelNov 26, 2024
@ViicosViicos mentioned this pull requestNov 26, 2024
36 tasks
@codspeed-hqCodSpeed HQ
Copy link

CodSpeed Performance Report

Merging#10984 willnot alter performance

Comparingdataclass-defer-build-fields (48ff78b) withmain (6f31f8f)

Summary

✅ 46 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic/_internal
  _dataclasses.py
Project Total 

This report was generated bypython-coverage-comment-action

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great, thanks for the simple fix!

@sydney-runklesydney-runkle merged commit120d7bc intomainDec 2, 2024
55 checks passed
@sydney-runklesydney-runkle deleted the dataclass-defer-build-fields branchDecember 2, 2024 15:39
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
2 participants
@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp