For Python < 3.10, we defineEllipsisType = type(Ellipsis) in_typing_extra.EllipsisType is then used in a type expression but pyright raises an error becauseEllipsisType is defined as variable.

Instead, we make use of theellipsis builtin, only available for type checkers (defined in typeshed) as a compatibility hack.

Change Summary

Related issue number

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Nov 25, 2024

Copy link

cloudflare-workers-and-pagesbot commentedNov 25, 2024•
edited
Loading

Deploying pydantic-docs with Cloudflare Pages

Latest commit:	`1fb04ac`
Status:	✅ Deploy successful!
Preview URL:	https://73a3bb43.pydantic-docs.pages.dev
Branch Preview URL:	https://ellipsis-compat.pydantic-docs.pages.dev

View logs

Viicosenabled auto-merge (squash)

November 25, 2024 17:21

Viicos mentioned this pull request

Nov 25, 2024

Known v2.10 Issues - Fixes in Progress#10910

Closed

36 tasks

Copy link

codspeed-hqbot commentedNov 25, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10972 willimprove performances by 5.55%

_{Comparingellipsis-compat (1fb04ac) withmain (1667c84)}

Summary

⚡ 1 improvements
✅ 45 untouched benchmarks

Benchmarks breakdown

	Benchmark	`main`	`ellipsis-compat`	Change
⚡	`test_getattr`	57.3 µs	54.3 µs	+5.55%

Copy link

Contributor

github-actionsbot commentedNov 25, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

Fix type hint ofField.default to be compatible with Python 3.8 and…

1fb04ac

… 3.9For Python < 3.10, we define `EllipsisType = type(Ellipsis)` in`_typing_extra`. `EllipsisType` is then used in a type expressionbut pyright raises an error because `EllipsisType` is defined asvariable.Instead, we make use of the `ellipsis` builtin, only availablefor type checkers (defined in typeshed) as a compatibility hack.

Viicos force-pushed theellipsis-compat branch from3b9ac56 to1fb04acCompare

November 25, 2024 17:27

sydney-runkle approved these changes

Nov 25, 2024

View reviewed changes

Copy link

Contributor

sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work, thanks

Viicos merged commita67002a intomain

Nov 25, 2024

54 checks passed

Viicos deleted the ellipsis-compat branch

November 25, 2024 18:18

sydney-runkle pushed a commit that referenced this pull request

Nov 26, 2024

Fix type hint ofField.default to be compatible with Python 3.8 and…

a9cf39c

… 3.9 (#10972)For Python < 3.10, we define `EllipsisType = type(Ellipsis)` in`_typing_extra`. `EllipsisType` is then used in a type expressionbut pyright raises an error because `EllipsisType` is defined asvariable.Instead, we make use of the `ellipsis` builtin, only availablefor type checkers (defined in typeshed) as a compatibility hack.

This was referencedDec 5, 2024

ci(backend): Addpoetry.lock checkSignificant-Gravitas/AutoGPT#8885

Merged

Avoid type checking error when using the ellipsis withField#10781

Merged

[v2.10] No overloads forField match the provided arguments#11052

Closed

Labels

relnotes-fix

Used for bugfixes.

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix type hint of`Field.default` to be compatible with Python 3.8 and 3.9#10972

Fix type hint of`Field.default` to be compatible with Python 3.8 and 3.9#10972

Uh oh!