Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix type hint ofField.default to be compatible with Python 3.8 and 3.9#10972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 1 commit intomainfromellipsis-compat
Nov 25, 2024

Conversation

@Viicos
Copy link
Member

Fixes#10971.

For Python < 3.10, we defineEllipsisType = type(Ellipsis) in_typing_extra.EllipsisType is then used in a type expression but pyright raises an error becauseEllipsisType is defined as variable.

Instead, we make use of theellipsis builtin, only available for type checkers (defined in typeshed) as a compatibility hack.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelNov 25, 2024
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pagesbot commentedNov 25, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:1fb04ac
Status: ✅  Deploy successful!
Preview URL:https://73a3bb43.pydantic-docs.pages.dev
Branch Preview URL:https://ellipsis-compat.pydantic-docs.pages.dev

View logs

@ViicosViicosenabled auto-merge (squash)November 25, 2024 17:21
@ViicosViicos mentioned this pull requestNov 25, 2024
36 tasks
@codspeed-hq
Copy link

codspeed-hqbot commentedNov 25, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10972 willimprove performances by 5.55%

Comparingellipsis-compat (1fb04ac) withmain (1667c84)

Summary

⚡ 1 improvements
✅ 45 untouched benchmarks

Benchmarks breakdown

Benchmarkmainellipsis-compatChange
⚡test_getattr57.3 µs54.3 µs+5.55%

@github-actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

… 3.9For Python < 3.10, we define `EllipsisType = type(Ellipsis)` in`_typing_extra`. `EllipsisType` is then used in a type expressionbut pyright raises an error because `EllipsisType` is defined asvariable.Instead, we make use of the `ellipsis` builtin, only availablefor type checkers (defined in typeshed) as a compatibility hack.
Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work, thanks

@ViicosViicos merged commita67002a intomainNov 25, 2024
54 checks passed
@ViicosViicos deleted the ellipsis-compat branchNovember 25, 2024 18:18
sydney-runkle pushed a commit that referenced this pull requestNov 26, 2024
… 3.9 (#10972)For Python < 3.10, we define `EllipsisType = type(Ellipsis)` in`_typing_extra`. `EllipsisType` is then used in a type expressionbut pyright raises an error because `EllipsisType` is defined asvariable.Instead, we make use of the `ellipsis` builtin, only availablefor type checkers (defined in typeshed) as a compatibility hack.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@sydney-runklesydney-runklesydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

relnotes-fixUsed for bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type of "Field" is partially unknown after v2.10

3 participants

@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp