This might not be the best approach, but relieves some pressure for now. Leans into the coupling betweenpydantic andpydantic-core. I think it's better to lean into this than to pretend it doesn't exist.

Working on docs test fixes

support secret and url serialization with manually implemented __pyda…

f8c177a

…ntic_serializer__

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Nov 22, 2024

Copy link

codspeed-hqbot commentedNov 22, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10947 willnot alter performance

_{Comparingeasier-ser (a84e306) withmain (15f693a)}

Summary

✅ 46 untouched benchmarks

fix docs tests

d5adf38

Copy link

cloudflare-workers-and-pagesbot commentedNov 22, 2024•
edited
Loading

Deploying pydantic-docs with Cloudflare Pages

Latest commit:	`a84e306`
Status:	✅ Deploy successful!
Preview URL:	https://9dc69f81.pydantic-docs.pages.dev
Branch Preview URL:	https://easier-ser.pydantic-docs.pages.dev

View logs

Copy link

Contributor

github-actionsbot commentedNov 22, 2024•
edited
Loading

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic/_internal
_fields.py
_generate_schema.py
_typing_extra.py
Project Total

_{This report was generated bypython-coverage-comment-action}

dmontagu approved these changes

Nov 22, 2024

View reviewed changes

sydney-runkle mentioned this pull request

Nov 22, 2024

Known v2.10 Issues - Fixes in Progress#10910

Closed

36 tasks

sydney-runkle requested a review fromdavidhewitt

November 22, 2024 16:02

davidhewitt approved these changes

Nov 25, 2024

View reviewed changes

Copy link

Contributor

davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This seems fine for now 👍

It would be nice in the long run to either decide this is what we want users to do too, or to find a better way to support types with__get_pydantic_core_schema__.