Revert "ci: use locally built pydantic-core with debug symbols#10942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Nov 22, 2024

Merged

Nov 22, 2024

Conversation

Copy link

Contributor

Codspeed broken with changes, temporarily reverting so we can do perf analysis in the meantime

Revert "ci: use locally built pydantic-core with debug symbols in ben…

9980020

…chmarks (#10886)"This reverts commit8c4b95a.

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Copy link

Latest commit:	`9980020`
Status:	✅ Deploy successful!
Preview URL:	https://6fb56c7c.pydantic-docs.pages.dev
Branch Preview URL:	https://revert-codspeed-ci.pydantic-docs.pages.dev

Copy link

_{Comparingrevert-codspeed-ci (9980020) withmain (ed29a35)}

❌ 17 regressions
✅ 29 untouched benchmarks

⚠️Please fix the performance issues oracknowledge them on CodSpeed.

	Benchmark	`main`	`revert-codspeed-ci`	Change
❌	`test_efficiency_with_highly_nested_examples`	719 µs	784.3 µs	-8.33%
❌	`test_list_of_models_serialization`	59.5 µs	63.5 µs	-6.27%
❌	`test_model_json_serialization`	60.5 µs	65.6 µs	-7.78%
❌	`test_simple_model_serialization`	32.6 µs	34.7 µs	-6.24%
❌	`test_complex_model_validation[__init__]`	54.4 µs	58.9 µs	-7.78%
❌	`test_complex_model_validation[model_validate]`	54.2 µs	59.4 µs	-8.77%
❌	`test_list_of_models_validation[__init__]`	94.3 µs	101.2 µs	-6.83%
❌	`test_list_of_models_validation[model_validate]`	92.1 µs	99.8 µs	-7.73%
❌	`test_nested_model_validation[__init__]`	56.7 µs	61.5 µs	-7.9%
❌	`test_nested_model_validation[model_validate]`	54.2 µs	58.8 µs	-7.83%
❌	`test_simple_model_validation[__init__]`	40 µs	42.3 µs	-5.34%
❌	`test_simple_model_validation[model_validate]`	41.2 µs	43.7 µs	-5.89%
❌	`test_north_star_dump_python`	15.9 ms	17 ms	-7%
❌	`test_north_star_validate_json`	53.4 ms	56.6 ms	-5.67%
❌	`test_north_star_validate_json_strict`	53.2 ms	56.4 ms	-5.61%
❌	`test_north_star_validate_python`	45.1 ms	48.2 ms	-6.49%
❌	`test_north_star_validate_python_strict`	27.2 ms	30.2 ms	-9.86%