Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.2k
Fix url constraint application#10922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codspeed-hqbot commentedNov 21, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
CodSpeed Performance ReportMerging#10922 willnot alter performanceComparing Summary
|
github-actionsbot commentedNov 21, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems correct with one simplification.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, hopefully we'll soon be able to rework this annotation application because the function-wrap check is quite unfortunate
Uh oh!
There was an error while loading.Please reload this page.
antazoey commentedNov 21, 2024
I used to be able to use FileURL for AnyUrl in my models (I have a field that can literally be AnyUrl, including file ones)... Should I make a separate issue or does this also fix that? Is there a way we can have a test for that use-case? |
yes, very much so, I'd like to rework the url types more - I think we could still reconsider validation on init, or at least go about it in a different way |
cloudflare-workers-and-pagesbot commentedNov 21, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Deploying pydantic-docs with |
Latest commit: | 21b2401 |
Status: | ✅ Deploy successful! |
Preview URL: | https://4e7b8150.pydantic-docs.pages.dev |
Branch Preview URL: | https://urls-str-constraints.pydantic-docs.pages.dev |
The issue is that |
73509ed
intomainUh oh!
There was an error while loading.Please reload this page.
antazoey commentedNov 21, 2024
OK I can do that. Is host required now only on 2.10 or was it required before but just not failing validation? |
Fix#10914